From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx184.postini.com [74.125.245.184]) by kanga.kvack.org (Postfix) with SMTP id E860A6B0032 for ; Thu, 27 Jun 2013 12:01:33 -0400 (EDT) Date: Thu, 27 Jun 2013 18:01:27 +0200 From: Peter Zijlstra Subject: Re: [PATCH 5/8] sched: Favour moving tasks towards the preferred node Message-ID: <20130627160127.GY28407@twins.programming.kicks-ass.net> References: <1372257487-9749-1-git-send-email-mgorman@suse.de> <1372257487-9749-6-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372257487-9749-6-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML On Wed, Jun 26, 2013 at 03:38:04PM +0100, Mel Gorman wrote: > @@ -3897,6 +3907,28 @@ task_hot(struct task_struct *p, u64 now, struct sched_domain *sd) > return delta < (s64)sysctl_sched_migration_cost; > } > > +/* Returns true if the destination node has incurred more faults */ > +static bool migrate_improves_locality(struct task_struct *p, struct lb_env *env) > +{ > + int src_nid, dst_nid; > + > + if (!p->numa_faults || !(env->sd->flags & SD_NUMA)) > + return false; > + > + src_nid = cpu_to_node(env->src_cpu); > + dst_nid = cpu_to_node(env->dst_cpu); > + > + if (src_nid == dst_nid) > + return false; > + > + if (p->numa_migrate_seq < sysctl_numa_balancing_settle_count && > + p->numa_preferred_nid == dst_nid) > + return true; > + > + return false; > +} > + This references ->numa_faults, which is declared under NUMA_BALANCING but lacks any such conditionality here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org