linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/8] sched: Track NUMA hinting faults on per-node basis
Date: Thu, 27 Jun 2013 17:57:48 +0200	[thread overview]
Message-ID: <20130627155748.GX28407@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1372257487-9749-3-git-send-email-mgorman@suse.de>

On Wed, Jun 26, 2013 at 03:38:01PM +0100, Mel Gorman wrote:
> @@ -503,6 +503,18 @@ DECLARE_PER_CPU(struct rq, runqueues);
>  #define cpu_curr(cpu)		(cpu_rq(cpu)->curr)
>  #define raw_rq()		(&__raw_get_cpu_var(runqueues))
>  
> +#ifdef CONFIG_NUMA_BALANCING
> +extern void sched_setnuma(struct task_struct *p, int node, int shared);

Stray line; you're introducing that function later with a different
signature.

> +static inline void task_numa_free(struct task_struct *p)
> +{
> +	kfree(p->numa_faults);
> +}
> +#else /* CONFIG_NUMA_BALANCING */
> +static inline void task_numa_free(struct task_struct *p)
> +{
> +}
> +#endif /* CONFIG_NUMA_BALANCING */
> +
>  #ifdef CONFIG_SMP
>  
>  #define rcu_dereference_check_sched_domain(p) \
> -- 
> 1.8.1.4
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-06-27 15:57 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 14:37 [PATCH 0/6] Basic scheduler support for automatic NUMA balancing Mel Gorman
2013-06-26 14:38 ` [PATCH 1/8] mm: numa: Document automatic NUMA balancing sysctls Mel Gorman
2013-06-26 14:38 ` [PATCH 2/8] sched: Track NUMA hinting faults on per-node basis Mel Gorman
2013-06-27 15:57   ` Peter Zijlstra [this message]
2013-06-28 12:22     ` Mel Gorman
2013-06-28  6:08   ` Srikar Dronamraju
2013-06-28  8:56     ` Peter Zijlstra
2013-06-28 12:30     ` Mel Gorman
2013-06-26 14:38 ` [PATCH 3/8] sched: Select a preferred node with the most numa hinting faults Mel Gorman
2013-06-28  6:14   ` Srikar Dronamraju
2013-06-28  8:59     ` Peter Zijlstra
2013-06-28 10:24       ` Srikar Dronamraju
2013-06-28 12:33     ` Mel Gorman
2013-06-26 14:38 ` [PATCH 4/8] sched: Update NUMA hinting faults once per scan Mel Gorman
2013-06-28  6:32   ` Srikar Dronamraju
2013-06-28  9:01     ` Peter Zijlstra
2013-06-26 14:38 ` [PATCH 5/8] sched: Favour moving tasks towards the preferred node Mel Gorman
2013-06-27 14:52   ` Peter Zijlstra
2013-06-27 14:53   ` Peter Zijlstra
2013-06-28 13:00     ` Mel Gorman
2013-06-27 16:01   ` Peter Zijlstra
2013-06-28 13:01     ` Mel Gorman
2013-06-27 16:11   ` Peter Zijlstra
2013-06-28 13:45     ` Mel Gorman
2013-06-28 15:10       ` Peter Zijlstra
2013-06-28  8:11   ` Srikar Dronamraju
2013-06-28  9:04     ` Peter Zijlstra
2013-06-28 10:07       ` Srikar Dronamraju
2013-06-28 10:24         ` Peter Zijlstra
2013-06-28 13:51         ` Mel Gorman
2013-06-28 17:14           ` Srikar Dronamraju
2013-06-28 17:34             ` Mel Gorman
2013-06-28 17:44               ` Srikar Dronamraju
2013-06-26 14:38 ` [PATCH 6/8] sched: Reschedule task on preferred NUMA node once selected Mel Gorman
2013-06-27 14:54   ` Peter Zijlstra
2013-06-28 13:54     ` Mel Gorman
2013-07-02 12:06   ` Srikar Dronamraju
2013-07-02 16:29     ` Mel Gorman
2013-07-02 18:17     ` Peter Zijlstra
2013-07-06  6:44       ` Srikar Dronamraju
2013-07-06 10:47         ` Peter Zijlstra
2013-07-02 18:15   ` Peter Zijlstra
2013-07-03  9:50     ` Peter Zijlstra
2013-07-03 15:28       ` Mel Gorman
2013-07-03 18:46         ` Peter Zijlstra
2013-06-26 14:38 ` [PATCH 7/8] sched: Split accounting of NUMA hinting faults that pass two-stage filter Mel Gorman
2013-06-27 14:56   ` Peter Zijlstra
2013-06-28 14:00     ` Mel Gorman
2013-06-28  7:00   ` Srikar Dronamraju
2013-06-28  9:36     ` Peter Zijlstra
2013-06-28 10:12       ` Srikar Dronamraju
2013-06-28 10:33         ` Peter Zijlstra
2013-06-28 14:29           ` Mel Gorman
2013-06-28 15:12             ` Peter Zijlstra
2013-06-26 14:38 ` [PATCH 8/8] sched: Increase NUMA PTE scanning when a new preferred node is selected Mel Gorman
2013-06-27 14:59 ` [PATCH 0/6] Basic scheduler support for automatic NUMA balancing Peter Zijlstra
2013-06-28 13:54 ` Srikar Dronamraju
2013-07-01  5:39   ` Srikar Dronamraju
2013-07-01  8:43     ` Mel Gorman
2013-07-02  5:28       ` Srikar Dronamraju
2013-07-02  7:46   ` Peter Zijlstra
2013-07-02  8:55     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130627155748.GX28407@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=aarcange@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox