From: Greg KH <gregkh@linuxfoundation.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "Michal Hocko" <mhocko@suse.cz>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Bob Liu" <lliubbo@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Cristian Rodríguez" <crrodriguez@opensuse.org>
Subject: Re: [PATCH] zcache: initialize module properly when zcache=FOO is given
Date: Wed, 26 Jun 2013 11:38:51 -0700 [thread overview]
Message-ID: <20130626183851.GA10591@kroah.com> (raw)
In-Reply-To: <20130626150116.GA6004@phenom.dumpdata.com>
On Wed, Jun 26, 2013 at 11:01:16AM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Jun 26, 2013 at 04:49:02PM +0200, Michal Hocko wrote:
> > 835f2f51 (staging: zcache: enable zcache to be built/loaded as a module)
> > introduced in 3.10-rc1 has introduced a bug for zcache=FOO module
> > parameter processing.
> >
> > zcache_comp_init return code doesn't agree with crypto_has_comp which
> > uses 1 for the success unlike zcache_comp_init which uses 0. This
> > causes module loading failure even if the given algorithm is supported:
> > [ 0.815330] zcache: compressor initialization failed
> >
> > Reported-by: Cristian Rodriguez <crrodriguez@opensuse.org>
> > Signed-off-by: Michal Hocko <mhocko@suse.cz>
>
> Looks OK to me.
>
> Cc-ing Greg.
That's nice, but can someone resend it in a format that I can apply it
in, with your ack?
thanks,
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-06-26 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 14:49 Michal Hocko
2013-06-26 15:01 ` Konrad Rzeszutek Wilk
2013-06-26 18:38 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626183851.GA10591@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=crrodriguez@opensuse.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mhocko@suse.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox