From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
David Rientjes <rientjes@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Rik van Riel <riel@redhat.com>,
Andrew Shewmaker <agshew@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Namjae Jeon <linkinjeon@gmail.com>,
Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/8] mm/writeback: fix wb_do_writeback exported unsafely
Date: Fri, 14 Jun 2013 17:41:05 +0800 [thread overview]
Message-ID: <20130614094105.GA10412@hacker.(null)> (raw)
In-Reply-To: <20130614093121.GB28555@hli22-desktop>
On Fri, Jun 14, 2013 at 05:31:21PM +0800, Haicheng Li wrote:
>
>On Fri, Jun 14, 2013 at 03:30:34PM +0800, Wanpeng Li wrote:
>> There is just one caller in fs-writeback.c call wb_do_writeback and
>> current codes unnecessary export it in header file, this patch fix
>> it by changing wb_do_writeback to static function.
>>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>
>Hi Wanpeng,
>
>A simliar patch has been merged in -next tree with commit#: 836f29bbb0f7a08dbdf1ed3ee704ef8aea81e56f
>
>BTW, actually this should have nothing to do with safety, just unnecessary to export it globally.
Oh, I miss your commit, anyway, good to see your work. ;-)
>> ---
>> fs/fs-writeback.c | 2 +-
>> include/linux/writeback.h | 1 -
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
>> index 3be5718..f892dec 100644
>> --- a/fs/fs-writeback.c
>> +++ b/fs/fs-writeback.c
>> @@ -959,7 +959,7 @@ static long wb_check_old_data_flush(struct bdi_writeback *wb)
>> /*
>> * Retrieve work items and do the writeback they describe
>> */
>> -long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
>> +static long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
>> {
>> struct backing_dev_info *bdi = wb->bdi;
>> struct wb_writeback_work *work;
>> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
>> index 579a500..e27468e 100644
>> --- a/include/linux/writeback.h
>> +++ b/include/linux/writeback.h
>> @@ -94,7 +94,6 @@ int try_to_writeback_inodes_sb_nr(struct super_block *, unsigned long nr,
>> void sync_inodes_sb(struct super_block *);
>> long writeback_inodes_wb(struct bdi_writeback *wb, long nr_pages,
>> enum wb_reason reason);
>> -long wb_do_writeback(struct bdi_writeback *wb, int force_wait);
>> void wakeup_flusher_threads(long nr_pages, enum wb_reason reason);
>> void inode_wait_for_writeback(struct inode *inode);
>>
>> --
>> 1.8.1.2
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-06-14 9:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 7:30 Wanpeng Li
2013-06-14 7:30 ` [PATCH 2/8] mm/writeback: remove wb_reason_name Wanpeng Li
2013-06-14 7:30 ` [PATCH 3/8] mm/writeback: Don't check force_wait to handle bdi->work_list Wanpeng Li
2013-06-14 7:30 ` [PATCH 4/8] mm/writeback: rename WB_REASON_FORKER_THREAD to WB_REASON_WORKER_THREAD Wanpeng Li
2013-06-14 17:57 ` Tejun Heo
2013-06-16 0:10 ` Wanpeng Li
2013-06-16 0:10 ` Wanpeng Li
2013-06-14 7:30 ` [PATCH 5/8] mm/page_alloc: fix blank in show_free_areas Wanpeng Li
2013-06-14 7:30 ` [PATCH 6/8] mm/page_alloc: fix doc for numa_zonelist_order Wanpeng Li
2013-06-14 7:30 ` [PATCH 7/8] mm/thp: fix doc for transparent huge zero page Wanpeng Li
2013-06-14 8:28 ` Kirill A. Shutemov
2013-06-14 7:30 ` [PATCH 8/8] mm/pgtable: Don't accumulate addr during pgd prepopulate pmd Wanpeng Li
2013-06-14 9:02 ` [PATCH 1/8] mm/writeback: fix wb_do_writeback exported unsafely Michal Hocko
2013-06-14 9:14 ` Wanpeng Li
2013-06-14 9:14 ` Wanpeng Li
2013-06-14 9:29 ` Kirill A. Shutemov
2013-06-14 9:31 ` Michal Hocko
2013-06-14 9:38 ` Zhang Yanfei
2013-06-14 9:31 ` Haicheng Li
2013-06-14 9:41 ` Wanpeng Li
2013-06-14 9:41 ` Wanpeng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130614094105.GA10412@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=agshew@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=jack@suse.cz \
--cc=jkosina@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linkinjeon@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox