From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx120.postini.com [74.125.245.120]) by kanga.kvack.org (Postfix) with SMTP id 404668D001E for ; Tue, 11 Jun 2013 12:24:33 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: <51B74A7A.1040707@sr71.net> References: <1370964919-16187-1-git-send-email-kirill.shutemov@linux.intel.com> <1370964919-16187-3-git-send-email-kirill.shutemov@linux.intel.com> <51B74A7A.1040707@sr71.net> Subject: Re: [PATCH 2/8] thp, mm: avoid PageUnevictable on active/inactive lru lists Content-Transfer-Encoding: 7bit Message-Id: <20130611162707.53DCBE0090@blue.fi.intel.com> Date: Tue, 11 Jun 2013 19:27:07 +0300 (EEST) Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Dave Hansen wrote: > On 06/11/2013 08:35 AM, Kirill A. Shutemov wrote: > > active/inactive lru lists can contain unevicable pages (i.e. ramfs pages > > that have been placed on the LRU lists when first allocated), but these > > pages must not have PageUnevictable set - otherwise shrink_[in]active_list > > goes crazy: > > I think it's also important here to note if this is a bug that can be > hit _currently_, or if this really is just a preparatory patch for > transparent huge page cache. I've mentioned in cover letter, that don't think the bug can be triggered on current upstream code. > From what I can see, this is _needed_ preparatory work, but it can also > stand on its own because it simplifies things. It should go in sooner > rather than later. Right. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org