From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx144.postini.com [74.125.245.144]) by kanga.kvack.org (Postfix) with SMTP id B637C6B00B6 for ; Wed, 29 May 2013 08:47:46 -0400 (EDT) Date: Wed, 29 May 2013 14:47:40 +0200 From: Peter Zijlstra Subject: Re: TLB and PTE coherency during munmap Message-ID: <20130529124740.GB27176@twins.programming.kicks-ass.net> References: <51A45861.1010008@gmail.com> <20130529122728.GA27176@twins.programming.kicks-ass.net> <51A5F7A7.5020604@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51A5F7A7.5020604@synopsys.com> Sender: owner-linux-mm@kvack.org List-ID: To: Vineet Gupta Cc: Max Filippov , KAMEZAWA Hiroyuki , linux-arch@vger.kernel.org, linux-mm@kvack.org, Ralf Baechle , Chris Zankel , Marc Gauthier , linux-xtensa@linux-xtensa.org, Hugh Dickins On Wed, May 29, 2013 at 06:12:15PM +0530, Vineet Gupta wrote: > It seems tlb_fast_mode() only affects the page free batching and won't affect the > TLB flush themselves unless ofcourse the batching runs out of space. It does, it will keep the pages around until after a flush. So you'll no longer free pages before having done a TLB flush. > FWIW, prior to your commit d16dfc550f5326 "mm: mmu_gather rework" > tlb_finish_mmu() right before the need_resced() which would have handled the > current situation. My proposal - please see my earlier email in thread is to reuse > the force_flush logic in zap_pte_range() to do this. I don't have earlier emails as my lkml folder is somewhat broken atm :/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org