From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx145.postini.com [74.125.245.145]) by kanga.kvack.org (Postfix) with SMTP id 077126B00D8 for ; Wed, 22 May 2013 11:11:36 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-34-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv4 33/39] thp, mm: implement do_huge_linear_fault() Content-Transfer-Encoding: 7bit Message-Id: <20130522151401.E69EDE0090@blue.fi.intel.com> Date: Wed, 22 May 2013 18:14:01 +0300 (EEST) Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Dave Hansen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Hillf Danton wrote: > On Sun, May 12, 2013 at 9:23 AM, Kirill A. Shutemov > wrote: > > @@ -3316,17 +3361,25 @@ static int __do_fault(struct mm_struct *mm, struct vm_area_struct *vma, > > if (unlikely(anon_vma_prepare(vma))) > > return VM_FAULT_OOM; > > > > - cow_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, address); > > + cow_page = alloc_fault_page_vma(vma, address, flags); > > if (!cow_page) > > - return VM_FAULT_OOM; > > + return VM_FAULT_OOM | VM_FAULT_FALLBACK; > > > > Fallback makes sense with !thp ? No, it's nop. handle_pte_fault() will notice only VM_FAULT_OOM. That's what we need. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org