From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com,
kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
linux-mm@kvack.org
Subject: Re: [PATCH v5 5/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory
Date: Tue, 14 May 2013 11:57:55 -0400 [thread overview]
Message-ID: <20130514155755.GH13674@redhat.com> (raw)
In-Reply-To: <20130514015734.18697.32447.stgit@localhost6.localdomain6>
On Tue, May 14, 2013 at 10:57:35AM +0900, HATAYAMA Daisuke wrote:
[..]
> +/* Merges all the PT_NOTE headers into one. */
> +static int __init merge_note_headers_elf32(char *elfptr, size_t *elfsz,
> + char **notesegptr, size_t *notesegsz,
> + struct list_head *vc_list)
> +{
Given that we are copying notes in second kernel, we are not using vc_list
in merge_note_headers() any more. So remove vc_list from paramter list
here.
For local parameters we could simply use notes_buf (instead of notesgptr)
and notes_sz (instead of notesgsz). It seems mroe readable.
Thanks
Vivek
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-14 15:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 1:57 [PATCH v5 0/8] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-14 1:57 ` [PATCH v5 1/8] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke
2013-05-14 14:45 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 2/8] vmcore: clean up read_vmcore() HATAYAMA Daisuke
2013-05-14 14:46 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 3/8] vmalloc: make find_vm_area check in range HATAYAMA Daisuke
2013-05-14 14:50 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 4/8] vmalloc: introduce remap_vmalloc_range_partial HATAYAMA Daisuke
2013-05-14 14:59 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 5/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory HATAYAMA Daisuke
2013-05-14 15:35 ` Vivek Goyal
2013-05-15 8:29 ` HATAYAMA Daisuke
2013-05-14 15:57 ` Vivek Goyal [this message]
2013-05-14 1:57 ` [PATCH v5 6/8] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list HATAYAMA Daisuke
2013-05-14 16:42 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects HATAYAMA Daisuke
2013-05-14 16:47 ` Vivek Goyal
2013-05-15 8:25 ` HATAYAMA Daisuke
2013-05-14 1:57 ` [PATCH v5 8/8] vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514155755.GH13674@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=jingbai.ma@hp.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lisa.mitchell@hp.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox