From: Michal Hocko <mhocko@suse.cz>
To: Andrey Vagin <avagin@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
Glauber Costa <glommer@parallels.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Balbir Singh <bsingharora@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] memcg: don't initialize kmem-cache destroying work for root caches
Date: Tue, 14 May 2013 16:44:27 +0200 [thread overview]
Message-ID: <20130514144427.GS5198@dhcp22.suse.cz> (raw)
In-Reply-To: <20130514144031.GR5198@dhcp22.suse.cz>
On Tue 14-05-13 16:40:31, Michal Hocko wrote:
> On Tue 14-05-13 16:38:38, Andrey Vagin wrote:
> > struct memcg_cache_params has a union. Different parts of this union are
> > used for root and non-root caches. A part with destroying work is used only
> > for non-root caches.
>
> but memcg_update_cache_size is called only for !root caches AFAICS
> (check memcg_update_all_caches)
Ohh, I am blind. memcg_update_all_caches skips all !root caches.
Then the patch looks correct. If Glauber has nothing against then thise
should be marked for stable (3.9)
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-14 14:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 12:38 Andrey Vagin
2013-05-14 14:40 ` Michal Hocko
2013-05-14 14:44 ` Michal Hocko [this message]
2013-05-14 14:49 ` Glauber Costa
2013-05-14 14:52 ` Michal Hocko
2013-05-14 16:08 ` Michal Hocko
2013-05-22 7:40 ` Andrew Vagin
2013-05-22 7:50 ` Li Zefan
2013-05-22 7:56 ` Andrew Vagin
2013-05-22 10:32 ` Michal Hocko
2013-05-28 22:53 ` Andrew Morton
2013-05-29 2:48 ` Glauber Costa
2013-05-30 10:59 ` Glauber Costa
2013-05-22 8:09 Andrey Vagin
2013-08-05 16:09 Andrey Vagin
2013-08-05 20:05 ` Andrew Morton
2013-08-05 21:01 ` Andrew Vagin
2013-08-05 21:16 ` Andrew Morton
2013-08-05 21:41 ` Andrew Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514144427.GS5198@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=avagin@openvz.org \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox