From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx195.postini.com [74.125.245.195]) by kanga.kvack.org (Postfix) with SMTP id 94E116B00E7 for ; Tue, 30 Apr 2013 10:49:54 -0400 (EDT) Date: Tue, 30 Apr 2013 15:49:50 +0100 From: Mel Gorman Subject: Re: [PATCH v4 07/31] shrinker: convert superblock shrinkers to new API Message-ID: <20130430144950.GG6415@suse.de> References: <1367018367-11278-1-git-send-email-glommer@openvz.org> <1367018367-11278-8-git-send-email-glommer@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1367018367-11278-8-git-send-email-glommer@openvz.org> Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Andrew Morton , Greg Thelen , kamezawa.hiroyu@jp.fujitsu.com, Michal Hocko , Johannes Weiner , Dave Chinner On Sat, Apr 27, 2013 at 03:19:03AM +0400, Glauber Costa wrote: > From: Dave Chinner > > Convert superblock shrinker to use the new count/scan API, and > propagate the API changes through to the filesystem callouts. The > filesystem callouts already use a count/scan API, so it's just > changing counters to longs to match the VM API. > > This requires the dentry and inode shrinker callouts to be converted > to the count/scan API. This is mainly a mechanical change. > > [ glommer: use mult_frac for fractional proportions, build fixes ] > Signed-off-by: Dave Chinner > Signed-off-by: Glauber Costa It's slightly clearer on seeing this patch why you went with long instead of unsigned long in the previous patch. It matched closer to what the shrinkers were already doing with their counters and of course they already understood -1 but as the API is being churned anyway, it would not hurt to use unsigned long for counters and ULONG_MAX for errors. I spotted no specific problem with this patch itself and there is some nice tidy-ups in there. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org