* RE: [next:akpm 522/1000] mm/huge_memory.c:189:24: sparse: Using plain integer as NULL pointer
[not found] <5171d291.z0O+vFet0jlVHN9L%fengguang.wu@intel.com>
@ 2013-04-22 11:10 ` Kirill A. Shutemov
0 siblings, 0 replies; only message in thread
From: Kirill A. Shutemov @ 2013-04-22 11:10 UTC (permalink / raw)
To: Andrew Morton; +Cc: Kirill A. Shutemov, kbuild test robot, linux-mm
kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> head: c9941b7ec7840ad33f5822c7f238157558d40132
> commit: 4b4928dfcbe7f45ab9a900de1e0847cc555fc935 [522/1000] thp: fix huge zero page logic for page with pfn == 0
>
>
> sparse warnings: (new ones prefixed by >>)
>
> >> mm/huge_memory.c:189:24: sparse: Using plain integer as NULL pointer
Thanks for report. The fix is below.
Andrew, could you fold it into original patch?
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index bc2a548..d46ea1e 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -186,7 +186,7 @@ retry:
HPAGE_PMD_ORDER);
if (!zero_page) {
count_vm_event(THP_ZERO_PAGE_ALLOC_FAILED);
- return 0;
+ return NULL;
}
count_vm_event(THP_ZERO_PAGE_ALLOC);
preempt_disable();
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-04-22 11:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <5171d291.z0O+vFet0jlVHN9L%fengguang.wu@intel.com>
2013-04-22 11:10 ` [next:akpm 522/1000] mm/huge_memory.c:189:24: sparse: Using plain integer as NULL pointer Kirill A. Shutemov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox