From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
kbuild test robot <fengguang.wu@intel.com>,
linux-mm@kvack.org
Subject: RE: [next:akpm 522/1000] mm/huge_memory.c:189:24: sparse: Using plain integer as NULL pointer
Date: Mon, 22 Apr 2013 14:10:10 +0300 (EEST) [thread overview]
Message-ID: <20130422111010.61A20E0085@blue.fi.intel.com> (raw)
In-Reply-To: <5171d291.z0O+vFet0jlVHN9L%fengguang.wu@intel.com>
kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> head: c9941b7ec7840ad33f5822c7f238157558d40132
> commit: 4b4928dfcbe7f45ab9a900de1e0847cc555fc935 [522/1000] thp: fix huge zero page logic for page with pfn == 0
>
>
> sparse warnings: (new ones prefixed by >>)
>
> >> mm/huge_memory.c:189:24: sparse: Using plain integer as NULL pointer
Thanks for report. The fix is below.
Andrew, could you fold it into original patch?
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index bc2a548..d46ea1e 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -186,7 +186,7 @@ retry:
HPAGE_PMD_ORDER);
if (!zero_page) {
count_vm_event(THP_ZERO_PAGE_ALLOC_FAILED);
- return 0;
+ return NULL;
}
count_vm_event(THP_ZERO_PAGE_ALLOC);
preempt_disable();
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
parent reply other threads:[~2013-04-22 11:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <5171d291.z0O+vFet0jlVHN9L%fengguang.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422111010.61A20E0085@blue.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox