From: Michal Hocko <mhocko@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH v5 2/3] fix hugetlb memory check in vma_dump_size()
Date: Thu, 11 Apr 2013 09:08:40 +0200 [thread overview]
Message-ID: <20130411070832.GA1488@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1304101448390.1526@chino.kir.corp.google.com>
On Wed 10-04-13 14:49:07, David Rientjes wrote:
> On Wed, 10 Apr 2013, Naoya Horiguchi wrote:
>
> > Documentation/filesystems/proc.txt says about coredump_filter bitmask,
> >
> > Note bit 0-4 doesn't effect any hugetlb memory. hugetlb memory are only
> > effected by bit 5-6.
> >
> > However current code can go into the subsequent flag checks of bit 0-4
> > for vma(VM_HUGETLB). So this patch inserts 'return' and makes it work
> > as written in the document.
> >
> > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > Reviewed-by: Rik van Riel <riel@redhat.com>
> > Acked-by: Michal Hocko <mhocko@suse.cz>
> > Reviewed-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
> > Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Cc: stable@vger.kernel.org
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> Stable for 2.6.34+.
I think it is only 3.7+ as well because VM_RESERVED stopped use before
(314e51b9).
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-11 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 16:17 [RESEND][PATCH v5 0/3] fix hugepage coredump Naoya Horiguchi
2013-04-10 16:17 ` [RESEND][PATCH v5 1/3] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB) Naoya Horiguchi
2013-04-10 21:46 ` David Rientjes
2013-04-10 16:17 ` [RESEND][PATCH v5 2/3] fix hugetlb memory check in vma_dump_size() Naoya Horiguchi
2013-04-10 21:49 ` David Rientjes
2013-04-11 7:08 ` Michal Hocko [this message]
2013-04-10 16:17 ` [RESEND][PATCH v5 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page() Naoya Horiguchi
2013-04-10 16:31 ` KOSAKI Motohiro
2013-04-10 20:21 ` Michal Hocko
2013-04-10 21:51 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411070832.GA1488@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=d.hatayama@jp.fujitsu.com \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox