From: Andrew Morton <akpm@linux-foundation.org>
To: Andrew Shewmaker <agshew@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, simon.jeons@gmail.com,
ric.masonn@gmail.com
Subject: Re: [PATCH v8 3/3] mm: reinititalise user and admin reserves if memory is added or removed
Date: Mon, 8 Apr 2013 13:57:39 -0700 [thread overview]
Message-ID: <20130408135739.a373580e624def371b542df5@linux-foundation.org> (raw)
In-Reply-To: <20130408190738.GC2321@localhost.localdomain>
On Mon, 8 Apr 2013 15:07:38 -0400 Andrew Shewmaker <agshew@gmail.com> wrote:
> This patch alters the admin and user reserves of the previous patches
> in this series when memory is added or removed.
>
> If memory is added and the reserves have been eliminated or increased above
> the default max, then we'll trust the admin.
>
> If memory is removed and there isn't enough free memory, then we
> need to reset the reserves.
>
> Otherwise keep the reserve set by the admin.
>
> The reserve reset code is the same as the reserve initialization code.
>
> Does this sound reasonable to other people? I figured that hot removal
> with too large of memory in the reserves was the most important case
> to get right.
>
> I tested hot addition and removal by triggering it via sysfs. The reserves
> shrunk when they were set high and memory was removed. They were reset
> higher when memory was added again.
I have added your Signed-off-by: to my copy of this patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-04-08 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 19:07 Andrew Shewmaker
2013-04-08 20:37 ` Andrew Morton
2013-04-08 21:00 ` Andrew Shewmaker
2013-04-09 22:19 ` Andrew Morton
2013-04-09 23:56 ` Andrew Shewmaker
2013-04-10 0:05 ` Simon Jeons
2013-04-10 0:11 ` Andrew Shewmaker
2013-04-10 0:14 ` Simon Jeons
2013-04-10 15:56 ` Andrew Shewmaker
2013-04-09 0:42 ` Andrew Shewmaker
2013-04-08 20:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408135739.a373580e624def371b542df5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=agshew@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ric.masonn@gmail.com \
--cc=simon.jeons@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox