linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxram@us.ibm.com, guz.fnst@cn.fujitsu.com, tmac@hp.com,
	isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com,
	tangchen@cn.fujitsu.com, jiang.liu@huawei.com
Subject: Re: [PATCH v2 0/3] Support memory hot-delete to boot memory
Date: Mon, 8 Apr 2013 13:44:38 -0700	[thread overview]
Message-ID: <20130408134438.2a4388a07163e10a37158eed@linux-foundation.org> (raw)
In-Reply-To: <1365440996-30981-1-git-send-email-toshi.kani@hp.com>

On Mon,  8 Apr 2013 11:09:53 -0600 Toshi Kani <toshi.kani@hp.com> wrote:

> Memory hot-delete to a memory range present at boot causes an
> error message in __release_region(), such as:
> 
>  Trying to free nonexistent resource <0000000070000000-0000000077ffffff>
> 
> Hot-delete operation still continues since __release_region() is 
> a void function, but the target memory range is not freed from
> iomem_resource as the result.  This also leads a failure in a 
> subsequent hot-add operation to the same memory range since the
> address range is still in-use in iomem_resource.
> 
> This problem happens because the granularity of memory resource ranges
> may be different between boot and hot-delete.

So we don't need this new code if CONFIG_MEMORY_HOTPLUG=n?  If so, can
we please arrange for it to not be present if the user doesn't need it?

>  During bootup,
> iomem_resource is set up from the boot descriptor table, such as EFI
> Memory Table and e820.  Each resource entry usually covers the whole
> contiguous memory range.  Hot-delete request, on the other hand, may
> target to a particular range of memory resource, and its size can be
> much smaller than the whole contiguous memory.  Since the existing
> release interfaces like __release_region() require a requested region
> to be exactly matched to a resource entry, they do not allow a partial
> resource to be released.
> 
> This patchset introduces release_mem_region_adjustable() for memory
> hot-delete operations, which allows releasing a partial memory range
> and adjusts remaining resource accordingly.  This patchset makes no
> changes to the existing interfaces since their restriction is still
> valid for I/O resources.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2013-04-08 20:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 17:09 Toshi Kani
2013-04-08 17:09 ` [PATCH v2 1/3] resource: Add __adjust_resource() for internal use Toshi Kani
2013-04-10  6:10   ` David Rientjes
2013-04-10 15:39     ` Toshi Kani
2013-04-08 17:09 ` [PATCH v2 2/3] resource: Add release_mem_region_adjustable() Toshi Kani
2013-04-10  6:16   ` David Rientjes
2013-04-10 16:36     ` Toshi Kani
2013-04-08 17:09 ` [PATCH v2 3/3] mm: Change __remove_pages() to call release_mem_region_adjustable() Toshi Kani
2013-04-08 20:44 ` Andrew Morton [this message]
2013-04-08 20:58   ` [PATCH v2 0/3] Support memory hot-delete to boot memory Toshi Kani
2013-04-10  5:52     ` David Rientjes
2013-04-10  6:07       ` [patch] mm, hotplug: avoid compiling memory hotremove functions when disabled David Rientjes
2013-04-10 17:29         ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130408134438.2a4388a07163e10a37158eed@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=jiang.liu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxram@us.ibm.com \
    --cc=tangchen@cn.fujitsu.com \
    --cc=tmac@hp.com \
    --cc=toshi.kani@hp.com \
    --cc=wency@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox