From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx115.postini.com [74.125.245.115]) by kanga.kvack.org (Postfix) with SMTP id 0EAFC6B00FC for ; Fri, 5 Apr 2013 09:46:36 -0400 (EDT) Date: Fri, 5 Apr 2013 15:46:35 +0200 From: Michal Hocko Subject: Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache Message-ID: <20130405134635.GH31132@dhcp22.suse.cz> References: <515BF233.6070308@huawei.com> <515BF275.5080408@huawei.com> <515E664E.5060005@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515E664E.5060005@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: Kamezawa Hiroyuki Cc: Li Zefan , linux-mm@kvack.org, LKML , Cgroups , Tejun Heo , Glauber Costa , Johannes Weiner On Fri 05-04-13 14:51:10, KAMEZAWA Hiroyuki wrote: > (2013/04/03 18:12), Li Zefan wrote: > > Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). > > > > Signed-off-by: Li Zefan > > --- > > mm/memcontrol.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 43ca91d..dafacb8 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -3191,7 +3191,7 @@ void memcg_release_cache(struct kmem_cache *s) > > list_del(&s->memcg_params->list); > > mutex_unlock(&memcg->slab_caches_mutex); > > > > - mem_cgroup_put(memcg); > > + css_put(&memcg->css); > > out: > > kfree(s->memcg_params); > > } > > @@ -3350,16 +3350,18 @@ static struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg, > > > > mutex_lock(&memcg_cache_mutex); > > new_cachep = cachep->memcg_params->memcg_caches[idx]; > > - if (new_cachep) > > + if (new_cachep) { > > + css_put(&memcg->css); > > goto out; > > + } > > Where css_get() against this is done ? As glauber explained in another email in this thread. It was __memcg_create_cache_enqueue which took the reference. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org