From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx165.postini.com [74.125.245.165]) by kanga.kvack.org (Postfix) with SMTP id DFE626B0005 for ; Wed, 3 Apr 2013 17:14:11 -0400 (EDT) Received: by mail-wg0-f43.google.com with SMTP id f12so2114207wgh.22 for ; Wed, 03 Apr 2013 14:14:10 -0700 (PDT) Date: Wed, 3 Apr 2013 23:14:06 +0200 From: Michal Hocko Subject: Re: [PATCH v3 2/3] fix hugetlb memory check in vma_dump_size() Message-ID: <20130403211354.GA27611@dhcp22.suse.cz> References: <1365014138-19589-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1365014138-19589-3-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365014138-19589-3-git-send-email-n-horiguchi@ah.jp.nec.com> Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: Andrew Morton , Mel Gorman , Hugh Dickins , Rik van Riel , KOSAKI Motohiro , Konstantin Khlebnikov , HATAYAMA Daisuke , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed 03-04-13 14:35:37, Naoya Horiguchi wrote: > Documentation/filesystems/proc.txt says about coredump_filter bitmask, > > Note bit 0-4 doesn't effect any hugetlb memory. hugetlb memory are only > effected by bit 5-6. > > However current code can go into the subsequent flag checks of bit 0-4 > for vma(VM_HUGETLB). So this patch inserts 'return' and makes it work > as written in the document. > > Signed-off-by: Naoya Horiguchi > Cc: stable@vger.kernel.org Just for the record. It should be stable for 3.7+ since (314e51b98) becuase then have lost VM_RESERVED check which used to stop hugetlb mappings. Acked-by: Michal Hocko > --- > fs/binfmt_elf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git v3.9-rc3.orig/fs/binfmt_elf.c v3.9-rc3/fs/binfmt_elf.c > index 3939829..86af964 100644 > --- v3.9-rc3.orig/fs/binfmt_elf.c > +++ v3.9-rc3/fs/binfmt_elf.c > @@ -1137,6 +1137,7 @@ static unsigned long vma_dump_size(struct vm_area_struct *vma, > goto whole; > if (!(vma->vm_flags & VM_SHARED) && FILTER(HUGETLB_PRIVATE)) > goto whole; > + return 0; > } > > /* Do not dump I/O mapped devices or special mappings */ > -- > 1.7.11.7 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org