From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: gregkh@linuxfoundation.org, dan.magenheimer@oracle.com,
fengguang.wu@intel.com, linux-mm@kvack.org,
akpm@linux-foundation.org, Bob Liu <bob.liu@oracle.com>
Subject: Re: [PATCH 2/2] drivers: staging: zcache: fix compile warning
Date: Tue, 2 Apr 2013 10:18:50 -0400 [thread overview]
Message-ID: <20130402141850.GE1754@phenom.dumpdata.com> (raw)
In-Reply-To: <1364870864-13888-2-git-send-email-bob.liu@oracle.com>
On Tue, Apr 02, 2013 at 10:47:43AM +0800, Bob Liu wrote:
> Fix below compile warning:
> staging/zcache/zcache-main.c: In function ‘zcache_autocreate_pool’:
> staging/zcache/zcache-main.c:1393:13: warning: ‘cli’ may be used uninitialized
> in this function [-Wuninitialized]
>
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/staging/zcache/zcache-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
> index ac75670..7999021 100644
> --- a/drivers/staging/zcache/zcache-main.c
> +++ b/drivers/staging/zcache/zcache-main.c
> @@ -1341,7 +1341,7 @@ static int zcache_local_new_pool(uint32_t flags)
> int zcache_autocreate_pool(unsigned int cli_id, unsigned int pool_id, bool eph)
> {
> struct tmem_pool *pool;
> - struct zcache_client *cli;
> + struct zcache_client *cli = NULL;
> uint32_t flags = eph ? 0 : TMEM_POOL_PERSIST;
> int ret = -1;
>
> --
> 1.7.10.4
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-02 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 2:47 [PATCH 1/2] drivers: staging: zcache: fix compile error Bob Liu
2013-04-02 2:47 ` [PATCH 2/2] drivers: staging: zcache: fix compile warning Bob Liu
2013-04-02 14:18 ` Konrad Rzeszutek Wilk [this message]
2013-04-02 14:18 ` [PATCH 1/2] drivers: staging: zcache: fix compile error Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402141850.GE1754@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox