From: Greg KH <gregkh@linuxfoundation.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Bob Liu <lliubbo@gmail.com>,
dan.magenheimer@oracle.com, fengguang.wu@intel.com,
linux-mm@kvack.org, Bob Liu <bob.liu@oracle.com>
Subject: Re: [PATCH] staging: zcache: fix compile error
Date: Mon, 1 Apr 2013 10:56:16 -0700 [thread overview]
Message-ID: <20130401175616.GA18333@kroah.com> (raw)
In-Reply-To: <20130401121736.GA11995@phenom.dumpdata.com>
On Mon, Apr 01, 2013 at 08:17:36AM -0400, Konrad Rzeszutek Wilk wrote:
> On Mon, Apr 01, 2013 at 11:50:47AM +0800, Bob Liu wrote:
> > --- a/drivers/staging/zcache/zcache-main.c
> > +++ b/drivers/staging/zcache/zcache-main.c
> > @@ -1753,9 +1753,7 @@ static int zcache_init(void)
> > namestr = "ramster";
> > ramster_register_pamops(&zcache_pamops);
> > }
> > -#ifdef CONFIG_DEBUG_FS
> > zcache_debugfs_init();
> > -#endif
> > if (zcache_enabled) {
> > unsigned int cpu;
> >
>
> That looks OK, and should be as a seperate patch - as there are no compilation
> failures with zcache-main.c
No, make it in the same patch, it is relevant here.
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-01 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 3:50 Bob Liu
2013-04-01 12:17 ` Konrad Rzeszutek Wilk
2013-04-01 17:56 ` Greg KH [this message]
2013-04-07 1:14 ` Ric Mason
2013-04-07 8:06 ` Bob Liu
2013-04-07 8:11 ` Ric Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401175616.GA18333@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bob.liu@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox