From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Russ Anderson <rja@sgi.com>, Ingo Molnar <mingo@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [patch] mm: speedup in __early_pfn_to_nid
Date: Mon, 25 Mar 2013 14:34:00 -0700 [thread overview]
Message-ID: <20130325143400.d226b1f7b64a209b86dd4151@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1303241727420.23613@chino.kir.corp.google.com>
On Sun, 24 Mar 2013 17:28:12 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
> On Sat, 23 Mar 2013, KOSAKI Motohiro wrote:
>
> > > --- linux.orig/mm/page_alloc.c 2013-03-19 16:09:03.736450861 -0500
> > > +++ linux/mm/page_alloc.c 2013-03-22 17:07:43.895405617 -0500
> > > @@ -4161,10 +4161,23 @@ int __meminit __early_pfn_to_nid(unsigne
> > > {
> > > unsigned long start_pfn, end_pfn;
> > > int i, nid;
> > > + /*
> > > + NOTE: The following SMP-unsafe globals are only used early
> > > + in boot when the kernel is running single-threaded.
> > > + */
> > > + static unsigned long last_start_pfn, last_end_pfn;
> > > + static int last_nid;
> >
> > Why don't you mark them __meminitdata? They seems freeable.
> >
>
> Um, defining them in a __meminit function places them in .meminit.data
> already.
I wish it did, but it doesn't.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-25 21:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 15:56 Russ Anderson
2013-03-19 3:56 ` David Rientjes
2013-03-20 22:32 ` Andrew Morton
2013-03-21 10:55 ` Ingo Molnar
2013-03-21 12:35 ` Michal Hocko
2013-03-21 18:03 ` Ingo Molnar
2013-03-25 21:26 ` Andrew Morton
2013-03-26 8:05 ` Ingo Molnar
2013-03-21 18:40 ` David Rientjes
2013-03-22 7:25 ` Ingo Molnar
2013-03-23 15:29 ` Russ Anderson
2013-03-23 20:37 ` Yinghai Lu
2013-03-25 2:11 ` Lin Feng
2013-03-25 21:56 ` Russ Anderson
2013-03-25 22:17 ` Yinghai Lu
2013-03-23 22:24 ` KOSAKI Motohiro
2013-03-25 0:28 ` David Rientjes
2013-03-25 21:34 ` Andrew Morton [this message]
2013-03-25 22:36 ` David Rientjes
2013-03-25 22:42 ` Andrew Morton
2013-03-24 7:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325143400.d226b1f7b64a209b86dd4151@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=rja@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox