From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Michal Hocko <mhocko@suse.cz>, Russ Anderson <rja@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Subject: Re: [patch] mm: speedup in __early_pfn_to_nid
Date: Mon, 25 Mar 2013 14:26:30 -0700 [thread overview]
Message-ID: <20130325142630.faf41b11416c2e4ac3d61550@linux-foundation.org> (raw)
In-Reply-To: <20130321180321.GB4185@gmail.com>
On Thu, 21 Mar 2013 19:03:21 +0100 Ingo Molnar <mingo@kernel.org> wrote:
> > IMO the local scope is more obvious as this is and should only be used
> > for caching purposes.
>
> It's a pattern we actively avoid in kernel code.
On the contrary, I always encourage people to move the static
definitions into function scope if possible. So the reader can see the
identifier's scope without having to search the whole file.
Unnecessarily giving the identifier file-scope seems weird.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-25 21:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 15:56 Russ Anderson
2013-03-19 3:56 ` David Rientjes
2013-03-20 22:32 ` Andrew Morton
2013-03-21 10:55 ` Ingo Molnar
2013-03-21 12:35 ` Michal Hocko
2013-03-21 18:03 ` Ingo Molnar
2013-03-25 21:26 ` Andrew Morton [this message]
2013-03-26 8:05 ` Ingo Molnar
2013-03-21 18:40 ` David Rientjes
2013-03-22 7:25 ` Ingo Molnar
2013-03-23 15:29 ` Russ Anderson
2013-03-23 20:37 ` Yinghai Lu
2013-03-25 2:11 ` Lin Feng
2013-03-25 21:56 ` Russ Anderson
2013-03-25 22:17 ` Yinghai Lu
2013-03-23 22:24 ` KOSAKI Motohiro
2013-03-25 0:28 ` David Rientjes
2013-03-25 21:34 ` Andrew Morton
2013-03-25 22:36 ` David Rientjes
2013-03-25 22:42 ` Andrew Morton
2013-03-24 7:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325142630.faf41b11416c2e4ac3d61550@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rja@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox