From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx152.postini.com [74.125.245.152]) by kanga.kvack.org (Postfix) with SMTP id 54C386B0089 for ; Mon, 25 Mar 2013 09:04:19 -0400 (EDT) Date: Mon, 25 Mar 2013 14:04:16 +0100 From: Michal Hocko Subject: Re: [PATCH 05/10] migrate: add hugepage migration code to migrate_pages() Message-ID: <20130325130416.GV2154@dhcp22.suse.cz> References: <1363983835-20184-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1363983835-20184-6-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363983835-20184-6-git-send-email-n-horiguchi@ah.jp.nec.com> Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Hugh Dickins , KOSAKI Motohiro , Andi Kleen , Hillf Danton , linux-kernel@vger.kernel.org On Fri 22-03-13 16:23:50, Naoya Horiguchi wrote: [...] > @@ -523,6 +544,11 @@ static inline int check_pmd_range(struct vm_area_struct *vma, pud_t *pud, > pmd = pmd_offset(pud, addr); > do { > next = pmd_addr_end(addr, end); > + if (pmd_huge(*pmd) && is_vm_hugetlb_page(vma)) { > + check_hugetlb_pmd_range(vma, pmd, nodes, > + flags, private); I am afraid this has the same issue with other huge page sizes I have mentioned earlier. > + continue; > + } > split_huge_page_pmd(vma, addr, pmd); > if (pmd_none_or_trans_huge_or_clear_bad(pmd)) > continue; [...] > @@ -1012,14 +1040,8 @@ static int migrate_to_node(struct mm_struct *mm, int source, int dest, > check_range(mm, mm->mmap->vm_start, mm->task_size, &nmask, > flags | MPOL_MF_DISCONTIG_OK, &pagelist); > > - if (!list_empty(&pagelist)) { > - err = migrate_pages(&pagelist, new_node_page, dest, > + return migrate_movable_pages(&pagelist, new_node_page, dest, > MIGRATE_SYNC, MR_SYSCALL); > - if (err) > - putback_lru_pages(&pagelist); > - } > - > - return err; This is really confusing. Why migrate_pages doesn't do putback cleanup on its own but migrate_movable_pages does? Please also move migrate_movable_pages definition to this patch. > } > > /* > -- > 1.7.11.7 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org