linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Woithe <jwoithe@atrad.com.au>
To: Raymond Jennings <shentino@gmail.com>
Cc: Hillf Danton <dhillf@gmail.com>,
	David Rientjes <rientjes@google.com>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Jonathan Woithe <jwoithe@atrad.com.au>
Subject: Re: OOM triggered with plenty of memory free
Date: Mon, 25 Mar 2013 12:54:45 +1030	[thread overview]
Message-ID: <20130325022445.GH29157@marvin.atrad.com.au> (raw)
In-Reply-To: <20130321070750.GV30145@marvin.atrad.com.au>

This post ties up a few loose ends in this thread which remained after my
21 March 2013 post.

 * The memory leak was not present in 2.6.36.

 * The patch to 2.6.35.11 at the end of this email (based on
   48e6b121605512d87f8da1ccd014313489c19630 from linux-stable) resolves the
   memory leak in 2.6.35.11.

This gives us a workable solution while we await fixes to current mainline
in the r8169 driver.  Once that's done we can revalidate our systems against
a more recent kernel and start shipping that.

Thanks to those who assisted with this issue.

Regards
  jonathan

--- a/net/netlink/af_netlink.c	2013-03-25 10:32:15.365781434 +1100
+++ b/net/netlink/af_netlink.c	2013-03-25 10:32:15.373782107 +1100
@@ -1387,6 +1387,8 @@ static int netlink_sendmsg(struct kiocb
 	err = netlink_unicast(sk, skb, dst_pid, msg->msg_flags&MSG_DONTWAIT);
 
 out:
+	scm_destroy(siocb->scm);
+	siocb->scm = NULL;
 	return err;
 }

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-03-25  2:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-16  9:25 Hillf Danton
2013-03-16  9:33 ` Raymond Jennings
2013-03-16 11:02   ` Jonathan Woithe
2013-03-20  5:47   ` Jonathan Woithe
2013-03-21  7:07   ` Jonathan Woithe
2013-03-25  2:24     ` Jonathan Woithe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-02-13  3:10 Jonathan Woithe
2013-02-13  3:30 ` David Rientjes
2013-02-13  4:25   ` Jonathan Woithe
2013-02-13 15:14     ` Dave Hansen
2013-02-13 22:49       ` Jonathan Woithe
2013-02-21  6:01       ` Jonathan Woithe
2013-02-26  6:39       ` Jonathan Woithe
2013-02-26 15:26         ` Dave Hansen
2013-02-26 20:54           ` Eric W. Biederman
2013-03-04  5:25             ` Jonathan Woithe
2013-02-20  5:50   ` Simon Jeons
2013-02-20  7:05     ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130325022445.GH29157@marvin.atrad.com.au \
    --to=jwoithe@atrad.com.au \
    --cc=dhillf@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=shentino@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox