From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx175.postini.com [74.125.245.175]) by kanga.kvack.org (Postfix) with SMTP id 74BE36B0095 for ; Fri, 22 Mar 2013 06:10:28 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: <514B336C.6070404@sr71.net> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-8-git-send-email-kirill.shutemov@linux.intel.com> <514B336C.6070404@sr71.net> Subject: Re: [PATCHv2, RFC 07/30] thp, mm: introduce mapping_can_have_hugepages() predicate Content-Transfer-Encoding: 7bit Message-Id: <20130322101211.34A5EE0085@blue.fi.intel.com> Date: Fri, 22 Mar 2013 12:12:11 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Dave Hansen wrote: > On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > > +static inline bool mapping_can_have_hugepages(struct address_space *m) > > +{ > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > > + gfp_t gfp_mask = mapping_gfp_mask(m); > > + return !!(gfp_mask & __GFP_COMP); > > + } > > + > > + return false; > > +} > > I did a quick search in all your patches and don't see __GFP_COMP > getting _set_ anywhere. Am I missing something? __GFP_COMP is part of GFP_TRANSHUGE. We set it for ramfs in patch 20/30. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org