From: Michal Hocko <mhocko@suse.cz>
To: Glauber Costa <glommer@parallels.com>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
kamezawa.hiroyu@jp.fujitsu.com, handai.szj@gmail.com,
anton.vorontsov@linaro.org, Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v2 4/5] memcg: do not call page_cgroup_init at system_boot
Date: Tue, 19 Mar 2013 15:06:35 +0100 [thread overview]
Message-ID: <20130319140635.GH7869@dhcp22.suse.cz> (raw)
In-Reply-To: <1362489058-3455-5-git-send-email-glommer@parallels.com>
On Tue 05-03-13 17:10:57, Glauber Costa wrote:
> If we are not using memcg, there is no reason why we should allocate
> this structure, that will be a memory waste at best. We can do better
> at least in the sparsemem case, and allocate it when the first cgroup
> is requested. It should now not panic on failure, and we have to handle
> this right.
lookup_page_cgroup needs a special handling as well. Callers are not
prepared to get NULL and the current code would even explode with
!CONFIG_DEBUG_VM.
Anyway, agreed with what Kame said. This is really hard to read. Would
it be possible to split it up somehow - sorry for not being more helpful
here...
> flatmem case is a bit more complicated, so that one is left out for
> the moment.
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> CC: Michal Hocko <mhocko@suse.cz>
> CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> CC: Johannes Weiner <hannes@cmpxchg.org>
> CC: Mel Gorman <mgorman@suse.de>
> CC: Andrew Morton <akpm@linux-foundation.org>
> ---
> include/linux/page_cgroup.h | 28 +++++----
> init/main.c | 2 -
> mm/memcontrol.c | 3 +-
> mm/page_cgroup.c | 150 ++++++++++++++++++++++++--------------------
> 4 files changed, 99 insertions(+), 84 deletions(-)
>
[...]
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-19 14:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 13:10 [PATCH v2 0/5] bypass root memcg charges if no memcgs are possible Glauber Costa
2013-03-05 13:10 ` [PATCH v2 1/5] memcg: make nocpu_base available for non hotplug Glauber Costa
2013-03-06 0:04 ` Kamezawa Hiroyuki
2013-03-19 11:07 ` Michal Hocko
2013-03-05 13:10 ` [PATCH v2 2/5] memcg: provide root figures from system totals Glauber Costa
2013-03-06 0:27 ` Kamezawa Hiroyuki
2013-03-06 8:30 ` Glauber Costa
2013-03-06 10:45 ` Kamezawa Hiroyuki
2013-03-06 10:52 ` Glauber Costa
2013-03-06 10:59 ` Kamezawa Hiroyuki
2013-03-13 6:58 ` Sha Zhengju
2013-03-13 9:15 ` Kamezawa Hiroyuki
2013-03-13 9:59 ` Sha Zhengju
2013-03-14 0:03 ` Kamezawa Hiroyuki
2013-03-06 10:50 ` Kamezawa Hiroyuki
2013-03-19 12:46 ` Michal Hocko
2013-03-19 12:55 ` Michal Hocko
2013-03-20 7:03 ` Glauber Costa
2013-03-20 8:03 ` Michal Hocko
2013-03-20 8:08 ` Glauber Costa
2013-03-20 8:18 ` Michal Hocko
2013-03-20 8:34 ` Glauber Costa
2013-03-20 8:58 ` Michal Hocko
2013-03-20 9:30 ` Glauber Costa
2013-03-21 6:08 ` Kamezawa Hiroyuki
2013-03-20 16:40 ` Anton Vorontsov
2013-03-20 7:04 ` Glauber Costa
2013-03-05 13:10 ` [PATCH v2 3/5] memcg: make it suck faster Glauber Costa
2013-03-06 0:46 ` Kamezawa Hiroyuki
2013-03-06 8:38 ` Glauber Costa
2013-03-06 10:54 ` Kamezawa Hiroyuki
2013-03-13 8:08 ` Sha Zhengju
2013-03-20 7:13 ` Glauber Costa
2013-03-19 13:58 ` Michal Hocko
2013-03-20 7:00 ` Glauber Costa
2013-03-20 8:13 ` Michal Hocko
2013-03-05 13:10 ` [PATCH v2 4/5] memcg: do not call page_cgroup_init at system_boot Glauber Costa
2013-03-06 1:07 ` Kamezawa Hiroyuki
2013-03-06 8:22 ` Glauber Costa
2013-03-19 14:06 ` Michal Hocko [this message]
2013-03-05 13:10 ` [PATCH v2 5/5] memcg: do not walk all the way to the root for memcg Glauber Costa
2013-03-06 1:08 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319140635.GH7869@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=handai.szj@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox