linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Yinghai Lu <yinghai@kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jiang Liu <liuj97@gmail.com>
Subject: Re: [PATCH 2/3] mm, nobootmem: clean-up of free_low_memory_core_early()
Date: Tue, 19 Mar 2013 14:50:42 +0900	[thread overview]
Message-ID: <20130319055042.GD8858@lge.com> (raw)
In-Reply-To: <1363670161-9214-2-git-send-email-iamjoonsoo.kim@lge.com>

On Tue, Mar 19, 2013 at 02:16:00PM +0900, Joonsoo Kim wrote:
> Remove unused argument and make function static,
> because there is no user outside of nobootmem.c
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> 
> diff --git a/include/linux/bootmem.h b/include/linux/bootmem.h
> index cdc3bab..5f0b0e1 100644
> --- a/include/linux/bootmem.h
> +++ b/include/linux/bootmem.h
> @@ -44,7 +44,6 @@ extern unsigned long init_bootmem_node(pg_data_t *pgdat,
>  				       unsigned long endpfn);
>  extern unsigned long init_bootmem(unsigned long addr, unsigned long memend);
>  
> -extern unsigned long free_low_memory_core_early(int nodeid);
>  extern unsigned long free_all_bootmem_node(pg_data_t *pgdat);
>  extern unsigned long free_all_bootmem(void);
>  
> diff --git a/mm/nobootmem.c b/mm/nobootmem.c
> index 4711e91..589c673 100644
> --- a/mm/nobootmem.c
> +++ b/mm/nobootmem.c
> @@ -120,7 +120,7 @@ static unsigned long __init __free_memory_core(phys_addr_t start,
>  	return end_pfn - start_pfn;
>  }
>  
> -unsigned long __init free_low_memory_core_early(int nodeid)
> +static unsigned long __init free_low_memory_core_early()
>  {
>  	unsigned long count = 0;
>  	phys_addr_t start, end, size;
> @@ -170,7 +170,7 @@ unsigned long __init free_all_bootmem(void)
>  	 *  because in some case like Node0 doesn't have RAM installed
>  	 *  low ram will be on Node1
>  	 */
> -	return free_low_memory_core_early(MAX_NUMNODES);
> +	return free_low_memory_core_early();
>  }
>  
>  /**
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Sorry, this patch makes build warning.
Below is fixed version.

-------------------->&------------------------

  reply	other threads:[~2013-03-19  5:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19  5:15 [PATCH 1/3] mm, nobootmem: fix wrong usage of max_low_pfn Joonsoo Kim
2013-03-19  5:16 ` [PATCH 2/3] mm, nobootmem: clean-up of free_low_memory_core_early() Joonsoo Kim
2013-03-19  5:50   ` Joonsoo Kim [this message]
2013-03-19  5:51   ` Yinghai Lu
2013-03-19  5:58     ` Joonsoo Kim
2013-03-19  5:16 ` [PATCH 3/3] mm, nobootmem: do memset() after memblock_reserve() Joonsoo Kim
2013-03-19  5:53   ` Yinghai Lu
2013-03-19  5:58     ` Joonsoo Kim
2013-03-19  5:47 ` [PATCH 1/3] mm, nobootmem: fix wrong usage of max_low_pfn Yinghai Lu
2013-03-19  6:25   ` Joonsoo Kim
2013-03-19  6:42     ` Joonsoo Kim
2013-03-19  7:35       ` Yinghai Lu
2013-03-19  8:07         ` Joonsoo Kim
2013-03-20 20:18           ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130319055042.GD8858@lge.com \
    --to=iamjoonsoo.kim@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuj97@gmail.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox