From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx190.postini.com [74.125.245.190]) by kanga.kvack.org (Postfix) with SMTP id EF5A06B0037 for ; Fri, 15 Mar 2013 09:25:37 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-15-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv2, RFC 14/30] thp, mm: naive support of thp in generic read/write routines Content-Transfer-Encoding: 7bit Message-Id: <20130315132716.AF225E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 15:27:16 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > wrote: > > + if (PageTransTail(page)) { > > + page_cache_release(page); > > + page = find_get_page(mapping, > > + index & ~HPAGE_CACHE_INDEX_MASK); > check page is valid, please. Good catch. Fixed. > > + if (!PageTransHuge(page)) { > > + page_cache_release(page); > > + goto find_page; > > + } > > + } -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org