From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id C17636B0037 for ; Fri, 15 Mar 2013 09:23:01 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-14-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv2, RFC 13/30] thp, mm: implement grab_cache_huge_page_write_begin() Content-Transfer-Encoding: 7bit Message-Id: <20130315132440.C4DF8E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 15:24:40 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > wrote: > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > +struct page *grab_cache_huge_page_write_begin(struct address_space *mapping, > > + pgoff_t index, unsigned flags); > > +#else > > +static inline struct page *grab_cache_huge_page_write_begin( > > + struct address_space *mapping, pgoff_t index, unsigned flags) > > +{ > build bug? Hm?. No. Why? > > + return NULL; > > +} > > +#endif > > > btw, how about grab_thp_write_begin? Sounds better, thanks. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org