From: Dave Jones <davej@redhat.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: richard -rw- weinberger <richard.weinberger@gmail.com>,
linux-mm@kvack.org, user-mode-linux-user@lists.sourceforge.net,
Linux Kernel <linux-kernel@vger.kernel.org>,
Davi Arnaut <davi.arnaut@gmail.com>
Subject: Re: SLUB + UML : WARNING: at mm/page_alloc.c:2386
Date: Thu, 14 Mar 2013 17:21:07 -0400 [thread overview]
Message-ID: <20130314212107.GA23056@redhat.com> (raw)
In-Reply-To: <514239F7.3050704@gmx.de>
On Thu, Mar 14, 2013 at 09:58:31PM +0100, Toralf Forster wrote:
> On 03/14/2013 09:51 PM, richard -rw- weinberger wrote:
> > Can you please re-run with the attached patch.
> > I'm wondering how much memory is requested.
> >>From reading the source I'd say it must be less than PAGE_SIZE.
> > But such a small allocation would not trigger the WARN_ON()...
>
>
> 2013-03-14T21:56:58.000+01:00 trinity sshd[1158]: pam_unix(sshd:session): session opened for user tfoerste by (uid=0)
> 2013-03-14T21:56:59.852+01:00 trinity kernel: memdup_user: -14
> 2013-03-14T21:56:59.852+01:00 trinity kernel: ------------[ cut here ]------------
> 2013-03-14T21:56:59.852+01:00 trinity kernel: WARNING: at mm/page_alloc.c:2386 __alloc_pages_nodemask+0x153/0x750()
> 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbd14: [<08342dd8>] dump_stack+0x22/0x24
> 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbd2c: [<0807d0da>] warn_slowpath_common+0x5a/0x80
> 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbd54: [<0807d1a3>] warn_slowpath_null+0x23/0x30
> 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbd64: [<080d3213>] __alloc_pages_nodemask+0x153/0x750
> 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbdf0: [<080d3838>] __get_free_pages+0x28/0x50
> 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbe08: [<080fc48f>] __kmalloc_track_caller+0x3f/0x180
> 2013-03-14T21:56:59.852+01:00 trinity kernel: 38bfbe30: [<080dec82>] memdup_user+0x32/0x70
> 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbe4c: [<080dee7e>] strndup_user+0x3e/0x60
> 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbe68: [<0811b440>] copy_mount_string+0x30/0x50
> 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbe7c: [<0811be0a>] sys_mount+0x1a/0xe0
> 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbeac: [<08062a92>] handle_syscall+0x82/0xb0
> 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbef4: [<08074e7d>] userspace+0x46d/0x590
> 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbfec: [<0805f7cc>] fork_handler+0x6c/0x70
> 2013-03-14T21:56:59.853+01:00 trinity kernel: 38bfbffc: [<5a5a5a5a>] 0x5a5a5a5a
> 2013-03-14T21:56:59.853+01:00 trinity kernel:
> 2013-03-14T21:56:59.853+01:00 trinity kernel: ---[ end trace 5bf182a223bd623c ]---
> 2013-03-14T21:56:59.853+01:00 trinity kernel: memdup_user: -14
hah, strndup_user taking a signed long instead of a size_t as it's length arg.
either it needs to change, or it needs an explicit check for < 1
I wonder how many other paths make it possible to pass negative numbers here.
Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-14 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 19:07 SLAB " Toralf Förster
2013-03-14 19:53 ` richard -rw- weinberger
2013-03-14 20:51 ` richard -rw- weinberger
2013-03-14 20:58 ` SLUB " Toralf Förster
2013-03-14 21:21 ` Dave Jones [this message]
2013-03-14 21:24 ` Toralf Förster
2013-03-14 23:10 ` richard -rw- weinberger
2013-03-15 18:44 ` Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314212107.GA23056@redhat.com \
--to=davej@redhat.com \
--cc=davi.arnaut@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weinberger@gmail.com \
--cc=toralf.foerster@gmx.de \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox