From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx192.postini.com [74.125.245.192]) by kanga.kvack.org (Postfix) with SMTP id 0433A6B0036 for ; Thu, 14 Mar 2013 11:01:20 -0400 (EDT) Date: Thu, 14 Mar 2013 16:01:12 +0100 From: Michal Hocko Subject: Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions Message-ID: <20130314150112.GD11636@dhcp22.suse.cz> References: <1363114106-30251-1-git-send-email-gerald.schaefer@de.ibm.com> <1363114106-30251-2-git-send-email-gerald.schaefer@de.ibm.com> <20130314131404.GH11631@dhcp22.suse.cz> <20130314151109.5b6927ce@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130314151109.5b6927ce@thinkpad> Sender: owner-linux-mm@kvack.org List-ID: To: Gerald Schaefer Cc: Andrew Morton , Mel Gorman , Hugh Dickins , Hillf Danton , Tony Luck , Fenghua Yu , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Paul Mundt , "David S. Miller" , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Martin Schwidefsky , Heiko Carstens On Thu 14-03-13 15:11:09, Gerald Schaefer wrote: > On Thu, 14 Mar 2013 14:14:04 +0100 > Michal Hocko wrote: > > > On Tue 12-03-13 19:48:26, Gerald Schaefer wrote: > > > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > > > another difference in the pte layout vs. the pmd layout on s390, > > > thoroughly breaking the s390 support for hugetlbfs. This requires > > > replacing some more pte_xxx functions in mm/hugetlbfs.c with a > > > huge_pte_xxx version. > > > > > > This patch introduces those huge_pte_xxx functions and their > > > implementation on all architectures supporting hugetlbfs. This change > > > will be a no-op for all architectures other than s390. > > > > > > Signed-off-by: Gerald Schaefer > > > --- > > > arch/ia64/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > > > arch/mips/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > > > arch/powerpc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > > > arch/s390/include/asm/hugetlb.h | 56 +++++++++++++++++++++++++++++++++++++- > > > arch/s390/include/asm/pgtable.h | 20 -------------- > > > arch/s390/mm/hugetlbpage.c | 2 +- > > > arch/sh/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > > > arch/sparc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > > > arch/tile/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > > > arch/x86/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > > > mm/hugetlb.c | 23 ++++++++-------- > > > 11 files changed, 320 insertions(+), 33 deletions(-) > > > > Ouch, this adds a lot of code that is almost same for all archs except > > for some. Can we just make one common definition and define only those > > that differ, please? > > [...] > > Ok, seems like I misinterpreted the ugliness of HAVE_ARCH_xxx vs. code > duplication. Paul Mundt also suggested going for an asm-generic/hugetlb.h > approach. I'll send a new patch soon. Oh, I have missed that answer so sorry for duplication. Anyway, having asm-generic and HAVE_ARCH_xxx sounds much better to me for this case as the duplication is really big. Thanks -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org