From: Andrew Morton <akpm@linux-foundation.org>
To: Andrew Shewmaker <agshew@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, simon.jeons@gmail.com,
ric.masonn@gmail.com
Subject: Re: [PATCH v5 1/2] mm: limit growth of 3% hardcoded other user reserve
Date: Wed, 13 Mar 2013 14:01:02 -0700 [thread overview]
Message-ID: <20130313140102.234330566fd08a0c8e4e2732@linux-foundation.org> (raw)
In-Reply-To: <20130307015553.GA5495@localhost.localdomain>
On Wed, 6 Mar 2013 20:55:53 -0500 Andrew Shewmaker <agshew@gmail.com> wrote:
> Should I enforce a minimum for the admin reserve? 8MB/128MB for the
> overcommit guess/never modes? I was hesitant to do that since my
> numbers are based a full-featured distro's versions of login, bash,
> etc. A more svelte distro based on BusyBox might want different
> minimums.
I'd say not. It requires CAP_SYS_ADMIN and we generally prefer to give
root the flexibility to shoot his foot off if he feels so inclined.
> I have a question concerning the variable names. Might a person
> looking at the source be confused why admin_reserve_kbytes and
> user_reserve_kbytes are not included in totalreserve_pages? Should
> I use a word other than "reserve" in the names, like "safetynet"?
> I can't think of anything better. Maybe it isn't a concern, but
> I didn't want to cause confusion.
mm.. I wouldn't worry about it personally. As long as we have nice
comments at the various definition sites, readers should be able to
work out the difference quite easily.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-03-13 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 23:52 Andrew Shewmaker
2013-03-12 23:01 ` Andrew Morton
2013-03-07 1:55 ` Andrew Shewmaker
2013-03-13 21:01 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313140102.234330566fd08a0c8e4e2732@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=agshew@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ric.masonn@gmail.com \
--cc=simon.jeons@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox