From: Johannes Weiner <hannes@cmpxchg.org>
To: Zhang Yanfei <zhangyanfei.yes@gmail.com>
Cc: akpm@linux-foundation.org, Linux MM <linux-mm@kvack.org>,
mgorman@suse.de, minchan@kernel.org,
kamezawa.hiroyu@jp.fujitsu.com, m.szyprowski@samsung.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] mm: rename confusing function names
Date: Tue, 5 Feb 2013 14:26:40 -0500 [thread overview]
Message-ID: <20130205192640.GC6481@cmpxchg.org> (raw)
In-Reply-To: <51113CE3.5090000@gmail.com>
On Wed, Feb 06, 2013 at 01:09:55AM +0800, Zhang Yanfei wrote:
> Function nr_free_zone_pages, nr_free_buffer_pages and nr_free_pagecache_pages
> are horribly badly named, they count present_pages - pages_high within zones
> instead of free pages, so why not rename them to reasonable names, not cofusing
> people.
>
> patch2 and patch3 are based on patch1. So please apply patch1 first.
>
> Zhang Yanfei (3):
> mm: rename nr_free_zone_pages to nr_free_zone_high_pages
> mm: rename nr_free_buffer_pages to nr_free_buffer_high_pages
> mm: rename nr_free_pagecache_pages to nr_free_pagecache_high_pages
I don't feel that this is an improvement.
As you said, the "free" is already misleading, because those pages
might all be allocated. "High" makes me think not just of highmem,
but drug abuse in general.
nr_available_*_pages? I don't know, but if we go through with all
that churn, it had better improve something.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-05 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 17:09 Zhang Yanfei
2013-02-05 17:11 ` [PATCH 1/3] mm: rename nr_free_zone_pages to nr_free_zone_high_pages Zhang Yanfei
2013-02-05 17:13 ` [PATCH 2/3] mm: rename nr_free_buffer_pages to nr_free_buffer_high_pages Zhang Yanfei
2013-02-05 17:14 ` [PATCH 3/3] mm: rename nr_free_pagecache_pages to nr_free_pagecache_high_pages Zhang Yanfei
2013-02-05 19:26 ` Johannes Weiner [this message]
2013-02-05 22:13 ` [PATCH 0/3] mm: rename confusing function names Andrew Morton
2013-02-06 1:06 ` Zhang Yanfei
2013-02-06 1:20 ` Andrew Morton
2013-02-06 1:34 ` Zhang Yanfei
2013-02-06 1:58 ` Andrew Morton
2013-02-08 13:34 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205192640.GC6481@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=zhangyanfei.yes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox