From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 3/3] memcg: cleanup mem_cgroup_init comment
Date: Tue, 5 Feb 2013 13:16:17 -0500 [thread overview]
Message-ID: <20130205181617.GC993@cmpxchg.org> (raw)
In-Reply-To: <1360081441-1960-4-git-send-email-mhocko@suse.cz>
On Tue, Feb 05, 2013 at 05:24:01PM +0100, Michal Hocko wrote:
> We should encourage all memcg controller initialization independent on
> a specific mem_cgroup to be done here rather than exploit css_alloc
> callback and assume that nothing happens before root cgroup is created.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
It seems a little strange to document that the subsystem init function
should be used for initializing the subsystem. But your new comment
is better than the old comment :-)
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-05 18:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 16:23 [PATCH 0/3] cleanup memcg controller initialization Michal Hocko
2013-02-05 16:23 ` [PATCH 1/3] memcg: move mem_cgroup_soft_limit_tree_init to mem_cgroup_init Michal Hocko
2013-02-05 18:01 ` Johannes Weiner
2013-02-05 16:24 ` [PATCH 2/3] memcg: move memcg_stock initialization " Michal Hocko
2013-02-05 18:13 ` Johannes Weiner
2013-02-05 16:24 ` [PATCH 3/3] memcg: cleanup mem_cgroup_init comment Michal Hocko
2013-02-05 18:16 ` Johannes Weiner [this message]
2013-02-05 16:59 ` [PATCH 0/3] cleanup memcg controller initialization Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205181617.GC993@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox