From: Minchan Kim <minchan@kernel.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matt Sealey <matt@genesi-usa.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Nitin Gupta <ngupta@vflare.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>
Subject: Re: [PATCH] zsmalloc: Fix TLB coherency and build problem
Date: Mon, 4 Feb 2013 08:50:52 +0900 [thread overview]
Message-ID: <20130203235052.GB2688@blaptop> (raw)
In-Reply-To: <20130201140218.GN23505@n2100.arm.linux.org.uk>
On Fri, Feb 01, 2013 at 02:02:18PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 28, 2013 at 10:00:08AM +0900, Minchan Kim wrote:
> > @@ -663,7 +661,7 @@ static inline void __zs_unmap_object(struct mapping_area *area,
> >
> > flush_cache_vunmap(addr, end);
> > unmap_kernel_range_noflush(addr, PAGE_SIZE * 2);
> > - local_flush_tlb_kernel_range(addr, end);
> > + flush_tlb_kernel_range(addr, end);
>
> void unmap_kernel_range_noflush(unsigned long addr, unsigned long size)
> {
> vunmap_page_range(addr, addr + size);
> }
>
> void unmap_kernel_range(unsigned long addr, unsigned long size)
> {
> unsigned long end = addr + size;
>
> flush_cache_vunmap(addr, end);
> vunmap_page_range(addr, end);
> flush_tlb_kernel_range(addr, end);
> }
>
> So, given the above, what would be different between:
>
> unsigned long end = addr + (PAGE_SIZE * 2);
>
> flush_cache_vunmap(addr, end);
> unmap_kernel_range_noflush(addr, PAGE_SIZE * 2);
> flush_tlb_kernel_range(addr, end);
>
> (which is what it becomes after your change) and
>
> unmap_kernel_range(addr, PAGE_SIZE * 2);
>
> ?
Good point. I will clean it up.
Thanks.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-03 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 1:00 Minchan Kim
2013-01-30 2:48 ` Minchan Kim
2013-02-01 13:02 ` Konrad Rzeszutek Wilk
2013-02-01 14:02 ` Russell King - ARM Linux
2013-02-03 23:50 ` Minchan Kim [this message]
2013-02-19 10:07 ` Simon Jeons
2013-02-19 23:45 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203235052.GB2688@blaptop \
--to=minchan@kernel.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=matt@genesi-usa.com \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox