From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
torvalds@linux-foundation.org
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
devel@driverdev.osuosl.org,
Dan Magenheimer <dan.magenheimer@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH] staging: zsmalloc: remove unused pool name
Date: Thu, 31 Jan 2013 21:11:50 -0500 [thread overview]
Message-ID: <20130201021149.GB3416@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <20130131053235.GD3228@kroah.com>
> > > {sigh} you just made me have to edit your patch by hand, you now owe me
> > > a beer...
> > >
> > Should we codify that :-)
> >
> >
> > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> > index c379a2a..f879c60 100644
> > --- a/Documentation/SubmittingPatches
> > +++ b/Documentation/SubmittingPatches
> > @@ -94,6 +94,7 @@ includes updates for subsystem X. Please apply."
> > The maintainer will thank you if you write your patch description in a
> > form which can be easily pulled into Linux's source code management
> > system, git, as a "commit log". See #15, below.
> > +If the maintainer has to hand-edit your patch, you owe them a beer.
> >
> > If your description starts to get long, that's a sign that you probably
> > need to split up your patch. See #3, next.
>
> Yes we do need to codify this, but let's be fair, not everyone likes
> beer:
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index c379a2a..d1bec01 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -93,7 +93,9 @@ includes updates for subsystem X. Please apply."
>
> The maintainer will thank you if you write your patch description in a
> form which can be easily pulled into Linux's source code management
> -system, git, as a "commit log". See #15, below.
> +system, git, as a "commit log". See #15, below. If the maintainer has
> +to hand-edit your patch, you owe them the beverage of their choice the
> +next time you see them.
>
> If your description starts to get long, that's a sign that you probably
> need to split up your patch. See #3, next.
Does that mean you owe Linus a whiskey bottle since you didn't properly
sign this patch :-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-01 2:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 17:46 [PATCH 0/4] staging: zsmalloc: various cleanups/improvments Seth Jennings
2013-01-25 17:46 ` [PATCH 1/4] staging: zsmalloc: add gfp flags to zs_create_pool Seth Jennings
2013-01-28 3:39 ` Minchan Kim
2013-01-28 15:16 ` Konrad Rzeszutek Wilk
2013-01-28 23:33 ` Minchan Kim
2013-01-28 17:01 ` Seth Jennings
2013-01-28 23:38 ` Minchan Kim
2013-01-25 17:46 ` [PATCH 2/4] staging: zsmalloc: remove unused pool name Seth Jennings
2013-01-28 3:40 ` Minchan Kim
2013-01-30 4:16 ` Greg Kroah-Hartman
2013-01-30 15:36 ` [PATCH] " Seth Jennings
2013-01-30 15:41 ` Seth Jennings
2013-01-30 17:21 ` Greg Kroah-Hartman
2013-01-30 17:29 ` Konrad Rzeszutek Wilk
2013-01-31 5:32 ` Greg Kroah-Hartman
2013-02-01 2:11 ` Konrad Rzeszutek Wilk [this message]
2013-01-30 17:33 ` Seth Jennings
2013-01-25 17:46 ` [PATCH 3/4] staging: zsmalloc: add page alloc/free callbacks Seth Jennings
2013-01-28 3:42 ` Minchan Kim
2013-01-25 17:46 ` [PATCH 4/4] staging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE Seth Jennings
2013-01-28 3:44 ` Minchan Kim
2013-01-28 3:47 ` [PATCH 0/4] staging: zsmalloc: various cleanups/improvments Minchan Kim
2013-01-28 17:07 ` Seth Jennings
2013-01-28 23:44 ` Minchan Kim
2013-01-30 4:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201021149.GB3416@konrad-lan.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=sjenning@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox