From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx158.postini.com [74.125.245.158]) by kanga.kvack.org (Postfix) with SMTP id DE9766B0002 for ; Mon, 28 Jan 2013 10:16:48 -0500 (EST) Date: Mon, 28 Jan 2013 10:16:38 -0500 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/4] staging: zsmalloc: add gfp flags to zs_create_pool Message-ID: <20130128151637.GC4838@konrad-lan.dumpdata.com> References: <1359135978-15119-1-git-send-email-sjenning@linux.vnet.ibm.com> <1359135978-15119-2-git-send-email-sjenning@linux.vnet.ibm.com> <20130128033944.GB3321@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130128033944.GB3321@blaptop> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Seth Jennings , Greg Kroah-Hartman , Andrew Morton , Dan Magenheimer , Nitin Gupta , Robert Jennings , linux-mm@kvack.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Mon, Jan 28, 2013 at 12:39:44PM +0900, Minchan Kim wrote: > Hi Seth, > > On Fri, Jan 25, 2013 at 11:46:15AM -0600, Seth Jennings wrote: > > zs_create_pool() currently takes a gfp flags argument > > that is used when growing the memory pool. However > > it is not used in allocating the metadata for the pool > > itself. That is currently hardcoded to GFP_KERNEL. > > > > zswap calls zs_create_pool() at swapon time which is done > > in atomic context, resulting in a "might sleep" warning. > > > > This patch changes the meaning of the flags argument in > > zs_create_pool() to mean the flags for the metadata allocation, > > and adds a flags argument to zs_malloc that will be used for > > memory pool growth if required. > > As I mentioned, I'm not strongly against with this patch but it > should be last resort in case of not being able to address > frontswap's init routine's dependency with swap_lock. > > I sent a patch and am waiting reply of Konrand or Dan. > If we can fix frontswap, it would be better rather than > changing zsmalloc. Could you point me to the subject/title of it please? Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org