linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Negative (setpoint-dirty) in bdi_position_ratio()
@ 2013-01-20  0:02 paul.szabo
  2013-01-22 23:54 ` Jan Kara
  2013-01-24 14:57 ` Fengguang Wu
  0 siblings, 2 replies; 10+ messages in thread
From: paul.szabo @ 2013-01-20  0:02 UTC (permalink / raw)
  To: linux-mm; +Cc: 695182, linux-kernel

In bdi_position_ratio(), get difference (setpoint-dirty) right even when
negative. Both setpoint and dirty are unsigned long, the difference was
zero-padded thus wrongly sign-extended to s64. This issue affects all
32-bit architectures, does not affect 64-bit architectures where long
and s64 are equivalent.

In this function, dirty is between freerun and limit, the pseudo-float x
is between [-1,1], expected to be negative about half the time. With
zero-padding, instead of a small negative x we obtained a large positive
one so bdi_position_ratio() returned garbage.

Casting the difference to s64 also prevents overflow with left-shift;
though normally these numbers are small and I never observed a 32-bit
overflow there.

(This patch does not solve the PAE OOM issue.)

Paul Szabo   psz@maths.usyd.edu.au   http://www.maths.usyd.edu.au/u/psz/
School of Mathematics and Statistics   University of Sydney    Australia

Reported-by: Paul Szabo <psz@maths.usyd.edu.au>
Reference: http://bugs.debian.org/695182
Signed-off-by: Paul Szabo <psz@maths.usyd.edu.au>

--- mm/page-writeback.c.old	2012-12-06 22:20:40.000000000 +1100
+++ mm/page-writeback.c	2013-01-20 07:47:55.000000000 +1100
@@ -559,7 +559,7 @@ static unsigned long bdi_position_ratio(
 	 *     => fast response on large errors; small oscillation near setpoint
 	 */
 	setpoint = (freerun + limit) / 2;
-	x = div_s64((setpoint - dirty) << RATELIMIT_CALC_SHIFT,
+	x = div_s64(((s64)setpoint - (s64)dirty) << RATELIMIT_CALC_SHIFT,
 		    limit - setpoint + 1);
 	pos_ratio = x;
 	pos_ratio = pos_ratio * x >> RATELIMIT_CALC_SHIFT;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2013-01-26  3:57 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-20  0:02 [PATCH] Negative (setpoint-dirty) in bdi_position_ratio() paul.szabo
2013-01-22 23:54 ` Jan Kara
2013-01-24 14:14   ` Fengguang Wu
2013-01-24 14:57 ` Fengguang Wu
2013-01-24 15:16   ` Jan Kara
2013-01-25  0:15     ` paul.szabo
2013-01-24 23:43   ` paul.szabo
2013-01-25  0:55     ` Fengguang Wu
2013-01-25  1:47       ` paul.szabo
2013-01-26  3:57       ` paul.szabo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox