From: Fengguang Wu <fengguang.wu@intel.com>
To: paul.szabo@sydney.edu.au
Cc: linux-mm@kvack.org, 695182@bugs.debian.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] Negative (setpoint-dirty) in bdi_position_ratio()
Date: Thu, 24 Jan 2013 22:57:07 +0800 [thread overview]
Message-ID: <20130124145707.GB12745@localhost> (raw)
In-Reply-To: <201301200002.r0K02Atl031280@como.maths.usyd.edu.au>
Hi Paul,
> (This patch does not solve the PAE OOM issue.)
You may try the below debug patch. The only way the writeback patches
should trigger OOM, I think, is for the number of dirty/writeback
pages going out of control.
Or more simple, you may show us the OOM dmesg which will contain the
number of dirty pages. Or run this in a continuous loop during your
tests, and see how the dirty numbers change before OOM:
while :
do
grep -E '(Dirty|Writeback)' /proc/meminfo
sleep 1
done
Thanks,
Fengguang
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 50f0824..cf1165a 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1147,6 +1147,16 @@ pause:
if (task_ratelimit)
break;
+ if (nr_dirty > dirty_thresh + dirty_thresh / 2) {
+ if (printk_ratelimit())
+ printk(KERN_WARNING "nr_dirty=%lu dirty_thresh=%lu task_ratelimit=%lu dirty_ratelimit=%lu pos_ratio=%lu\n",
+ nr_dirty,
+ dirty_thresh,
+ task_ratelimit,
+ dirty_ratelimit,
+ pos_ratio);
+ }
+
/*
* In the case of an unresponding NFS server and the NFS dirty
* pages exceeds dirty_thresh, give the other good bdi's a pipe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-24 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 0:02 paul.szabo
2013-01-22 23:54 ` Jan Kara
2013-01-24 14:14 ` Fengguang Wu
2013-01-24 14:57 ` Fengguang Wu [this message]
2013-01-24 15:16 ` Jan Kara
2013-01-25 0:15 ` paul.szabo
2013-01-24 23:43 ` paul.szabo
2013-01-25 0:55 ` Fengguang Wu
2013-01-25 1:47 ` paul.szabo
2013-01-26 3:57 ` paul.szabo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124145707.GB12745@localhost \
--to=fengguang.wu@intel.com \
--cc=695182@bugs.debian.org \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paul.szabo@sydney.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox