From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx133.postini.com [74.125.245.133]) by kanga.kvack.org (Postfix) with SMTP id 274AB6B0005 for ; Thu, 17 Jan 2013 19:42:24 -0500 (EST) Received: by mail-pa0-f50.google.com with SMTP id hz10so1793539pad.9 for ; Thu, 17 Jan 2013 16:42:23 -0800 (PST) Date: Thu, 17 Jan 2013 16:42:19 -0800 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/3] zram: force disksize setting before using zram Message-ID: <20130118004219.GB29380@kroah.com> References: <1358388769-30112-1-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358388769-30112-1-git-send-email-minchan@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nitin Gupta , Seth Jennings , Dan Magenheimer , Konrad Rzeszutek Wilk , Jerome Marchand , Pekka Enberg On Thu, Jan 17, 2013 at 11:12:47AM +0900, Minchan Kim wrote: > Now zram document syas "set disksize is optional" > but partly it's wrong. When you try to use zram firstly after > booting, you must set disksize, otherwise zram can't work because > zram gendisk's size is 0. But once you do it, you can use zram freely > after reset because reset doesn't reset to zero paradoxically. > So in this time, disksize setting is optional.:( > It's inconsitent for user behavior and not straightforward. > > This patch forces always setting disksize firstly before using zram. > Yes. It changes current behavior so someone could complain when > he upgrades zram. Apparently it could be a problem if zram is mainline > but it still lives in staging so behavior could be changed for right > way to go. Let them excuse. I don't know about changing this behavior. I need some acks from some of the other zram developers before I can take this, or any of the other patches in this series. thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org