From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-mips@linux-mips.org, Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: 3.8-rc1 build failure with MIPS/SPARSEMEM
Date: Sun, 30 Dec 2012 12:38:50 +0200 [thread overview]
Message-ID: <20121230103850.GA5424@otc-wbsnb-06> (raw)
In-Reply-To: <20121227121607.GA7097@blackmetal.musicnaut.iki.fi>
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
On Thu, Dec 27, 2012 at 02:16:07PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Wed, Dec 26, 2012 at 02:34:35AM +0200, Kirill A. Shutemov wrote:
> > On MIPS if SPARSEMEM is enabled we've got this:
> >
> > In file included from /home/kas/git/public/linux/arch/mips/include/asm/pgtable.h:552,
> > from include/linux/mm.h:44,
> > from arch/mips/kernel/asm-offsets.c:14:
> > include/asm-generic/pgtable.h: In function ‘my_zero_pfn’:
> > include/asm-generic/pgtable.h:466: error: implicit declaration of function ‘page_to_section’
> > In file included from arch/mips/kernel/asm-offsets.c:14:
> > include/linux/mm.h: At top level:
> > include/linux/mm.h:738: error: conflicting types for ‘page_to_section’
> > include/asm-generic/pgtable.h:466: note: previous implicit declaration of ‘page_to_section’ was here
> >
> > Due header files inter-dependencies, the only way I see to fix it is
> > convert my_zero_pfn() for __HAVE_COLOR_ZERO_PAGE to macros.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
>
> Thanks, this works.
>
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Andrew, could you take the patch?
--
Kirill A. Shutemov
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-30 10:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 12:27 Aaro Koskinen
2012-12-22 13:10 ` Kirill A. Shutemov
2012-12-22 13:31 ` Aaro Koskinen
2012-12-26 0:34 ` Kirill A. Shutemov
2012-12-27 12:16 ` Aaro Koskinen
2012-12-30 10:38 ` Kirill A. Shutemov [this message]
2013-01-14 15:16 ` Kirill A. Shutemov
2013-01-14 22:03 ` David Daney
2013-01-18 18:10 ` 3.8-rc4 build regression (was: Re: 3.8-rc1 build failure with MIPS/SPARSEMEM) David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121230103850.GA5424@otc-wbsnb-06 \
--to=kirill.shutemov@linux.intel.com \
--cc=aaro.koskinen@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox