From: Rafael Aquini <aquini@redhat.com>
To: Jeremy Eder <jeder@redhat.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH v2] mm: clean up transparent hugepage sysfs error messages
Date: Wed, 19 Dec 2012 11:44:13 -0200 [thread overview]
Message-ID: <20121219134412.GA5707@t510.redhat.com> (raw)
In-Reply-To: <1355921460-28501-1-git-send-email-jeder@redhat.com>
On Wed, Dec 19, 2012 at 07:51:00AM -0500, Jeremy Eder wrote:
> This patch clarifies error messages and corrects a few typos
> in the transparent hugepage sysfs init code.
>
> Signed-off-by: Jeremy Eder <jeder@redhat.com>
> ---
Acked-by: Rafael Aquini <aquini@redhat.com>
> mm/huge_memory.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 32754ee..9e894ed 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -574,19 +574,19 @@ static int __init hugepage_init_sysfs(struct kobject **hugepage_kobj)
>
> *hugepage_kobj = kobject_create_and_add("transparent_hugepage", mm_kobj);
> if (unlikely(!*hugepage_kobj)) {
> - printk(KERN_ERR "hugepage: failed kobject create\n");
> + printk(KERN_ERR "hugepage: failed to create transparent hugepage kobject\n");
> return -ENOMEM;
> }
>
> err = sysfs_create_group(*hugepage_kobj, &hugepage_attr_group);
> if (err) {
> - printk(KERN_ERR "hugepage: failed register hugeage group\n");
> + printk(KERN_ERR "hugepage: failed to register transparent hugepage group\n");
> goto delete_obj;
> }
>
> err = sysfs_create_group(*hugepage_kobj, &khugepaged_attr_group);
> if (err) {
> - printk(KERN_ERR "hugepage: failed register hugeage group\n");
> + printk(KERN_ERR "hugepage: failed to register transparent hugepage group\n");
> goto remove_hp_group;
> }
>
> --
> 1.7.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-12-19 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 12:51 Jeremy Eder
2012-12-19 13:44 ` Rafael Aquini [this message]
2012-12-19 21:52 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219134412.GA5707@t510.redhat.com \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jeder@redhat.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox