From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx169.postini.com [74.125.245.169]) by kanga.kvack.org (Postfix) with SMTP id BE1436B0044 for ; Fri, 14 Dec 2012 07:07:10 -0500 (EST) Date: Fri, 14 Dec 2012 13:07:07 +0100 From: Michal Hocko Subject: Re: [patch v2 3/6] memcg: rework mem_cgroup_iter to use cgroup iterators Message-ID: <20121214120707.GG6898@dhcp22.suse.cz> References: <1353955671-14385-1-git-send-email-mhocko@suse.cz> <1353955671-14385-4-git-send-email-mhocko@suse.cz> <20121211155432.GC1612@dhcp22.suse.cz> <20121212090652.GB32081@dhcp22.suse.cz> <20121212192441.GD10374@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Ying Han Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki , Johannes Weiner , Tejun Heo , Glauber Costa , Li Zefan On Thu 13-12-12 17:14:13, Ying Han wrote: [...] > I haven't tried this patch set yet. Before I am doing that, I am > curious whether changing the target reclaim to be consistent with > global reclaim something worthy to consider based my last reply: > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 53dcde9..3f158c5 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1911,20 +1911,6 @@ static void shrink_zone(struct zone *zone, > struct scan_control *sc) > > shrink_lruvec(lruvec, sc); > > - /* > - * Limit reclaim has historically picked one memcg and > - * scanned it with decreasing priority levels until > - * nr_to_reclaim had been reclaimed. This priority > - * cycle is thus over after a single memcg. > - * > - * Direct reclaim and kswapd, on the other hand, have > - * to scan all memory cgroups to fulfill the overall > - * scan target for the zone. > - */ > - if (!global_reclaim(sc)) { > - mem_cgroup_iter_break(root, memcg); > - break; > - } > memcg = mem_cgroup_iter(root, memcg, &reclaim); This wouldn't work because you would over-reclaim proportionally to the number of groups in the hierarchy. > } while (memcg); > } > > --Ying -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org