From: Michal Hocko <mhocko@suse.cz>
To: Ying Han <yinghan@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Tejun Heo <htejun@gmail.com>,
Glauber Costa <glommer@parallels.com>,
Li Zefan <lizefan@huawei.com>
Subject: Re: [patch v2 3/6] memcg: rework mem_cgroup_iter to use cgroup iterators
Date: Wed, 12 Dec 2012 20:24:41 +0100 [thread overview]
Message-ID: <20121212192441.GD10374@dhcp22.suse.cz> (raw)
In-Reply-To: <20121212090652.GB32081@dhcp22.suse.cz>
On Wed 12-12-12 10:06:52, Michal Hocko wrote:
> On Tue 11-12-12 14:36:10, Ying Han wrote:
[...]
> > One exception is mem_cgroup_iter_break(), where the loop terminates
> > with *leaked* refcnt and that is what the iter_break() needs to clean
> > up. We can not rely on the next caller of the loop since it might
> > never happen.
>
> Yes, this is true and I already have a half baked patch for that. I
> haven't posted it yet but it basically checks all node-zone-prio
> last_visited and removes itself from them on the way out in pre_destroy
> callback (I just need to cleanup "find a new last_visited" part and will
> post it).
And a half baked patch - just compile tested
---
next prev parent reply other threads:[~2012-12-12 19:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 18:47 rework mem_cgroup iterator Michal Hocko
2012-11-26 18:47 ` [patch v2 1/6] memcg: synchronize per-zone iterator access by a spinlock Michal Hocko
2012-11-26 18:47 ` [patch v2 2/6] memcg: keep prev's css alive for the whole mem_cgroup_iter Michal Hocko
2012-11-28 8:38 ` Kamezawa Hiroyuki
2012-11-26 18:47 ` [patch v2 3/6] memcg: rework mem_cgroup_iter to use cgroup iterators Michal Hocko
2012-11-28 8:47 ` Kamezawa Hiroyuki
2012-11-28 9:17 ` Michal Hocko
2012-11-28 9:23 ` Glauber Costa
2012-11-28 9:33 ` Michal Hocko
2012-11-28 9:35 ` Glauber Costa
2012-11-30 4:07 ` Kamezawa Hiroyuki
2012-12-07 3:39 ` Ying Han
2012-12-07 3:43 ` Ying Han
2012-12-07 8:58 ` Michal Hocko
2012-12-07 17:12 ` Ying Han
2012-12-07 17:27 ` Michal Hocko
2012-12-07 19:16 ` Ying Han
2012-12-07 19:35 ` Michal Hocko
2012-12-07 9:01 ` Michal Hocko
2012-12-09 16:59 ` Ying Han
2012-12-11 15:50 ` Michal Hocko
2012-12-11 16:15 ` Michal Hocko
2012-12-11 18:10 ` Michal Hocko
2012-12-11 22:43 ` Ying Han
2012-12-12 8:55 ` Michal Hocko
2012-12-12 17:57 ` Ying Han
2012-12-12 18:08 ` Michal Hocko
2012-12-11 22:31 ` Ying Han
2012-12-09 19:39 ` Ying Han
2012-12-11 15:54 ` Michal Hocko
2012-12-11 22:36 ` Ying Han
2012-12-12 9:06 ` Michal Hocko
2012-12-12 18:09 ` Ying Han
2012-12-12 18:34 ` Michal Hocko
2012-12-12 18:42 ` Michal Hocko
2012-12-14 1:06 ` Ying Han
2012-12-14 10:56 ` [PATCH] memcg,vmscan: do not break out targeted reclaim without reclaimed pages Michal Hocko
2012-12-12 19:24 ` Michal Hocko [this message]
2012-12-14 1:14 ` [patch v2 3/6] memcg: rework mem_cgroup_iter to use cgroup iterators Ying Han
2012-12-14 12:07 ` Michal Hocko
2012-12-14 23:08 ` Ying Han
2012-12-14 12:37 ` Michal Hocko
2012-11-26 18:47 ` [patch v2 4/6] memcg: simplify mem_cgroup_iter Michal Hocko
2012-11-28 8:52 ` Kamezawa Hiroyuki
2012-11-30 4:09 ` Kamezawa Hiroyuki
2012-12-09 17:01 ` Ying Han
2012-12-11 15:57 ` Michal Hocko
2012-12-11 4:35 ` Ying Han
2012-12-11 16:01 ` Michal Hocko
2012-12-11 22:52 ` Ying Han
2012-11-26 18:47 ` [patch v2 5/6] memcg: further " Michal Hocko
2012-11-30 4:10 ` Kamezawa Hiroyuki
2012-11-30 9:08 ` Glauber Costa
2012-11-30 10:23 ` Michal Hocko
2012-11-26 18:47 ` [patch v2 6/6] cgroup: remove css_get_next Michal Hocko
2012-11-30 4:12 ` Kamezawa Hiroyuki
2012-11-30 8:18 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212192441.GD10374@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=htejun@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox