From: Borislav Petkov <bp@alien8.de>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: WuJianguo <wujianguo@huawei.com>, Liujiang <jiang.liu@huawei.com>,
andi@firstfloor.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] MCE: fix an error of mce_bad_pages statistics
Date: Fri, 7 Dec 2012 08:46:43 +0100 [thread overview]
Message-ID: <20121207074643.GA27523@liondog.tnic> (raw)
In-Reply-To: <50C19C33.9030502@huawei.com>
On Fri, Dec 07, 2012 at 03:35:15PM +0800, Xishi Qiu wrote:
> Hi Borislav, you mean we should move this to the beginning of soft_offline_page()?
>
> soft_offline_page()
> {
> ...
> get_any_page()
> ...
> /*
> * Synchronized using the page lock with memory_failure()
> */
> if (PageHWPoison(page)) {
> unlock_page(page);
Basically yes, except without the unlock_page. Where do you do lock_page
earlier so that you need to unlock it now?
Thanks.
--
Regards/Gruss,
Boris.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-12-07 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 2:53 Xishi Qiu
2012-12-07 7:25 ` Borislav Petkov
2012-12-07 7:35 ` Xishi Qiu
2012-12-07 7:46 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207074643.GA27523@liondog.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qiuxishi@huawei.com \
--cc=wujianguo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox