From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx175.postini.com [74.125.245.175]) by kanga.kvack.org (Postfix) with SMTP id 67D2F6B006C for ; Tue, 27 Nov 2012 04:54:55 -0500 (EST) Date: Tue, 27 Nov 2012 10:54:52 +0100 From: Michal Hocko Subject: Re: [PATCH -mm] memcg: do not trigger OOM from add_to_page_cache_locked Message-ID: <20121127095452.GD20537@dhcp22.suse.cz> References: <20121122233434.3D5E35E6@pobox.sk> <20121123074023.GA24698@dhcp22.suse.cz> <20121123102137.10D6D653@pobox.sk> <20121123100438.GF24698@dhcp22.suse.cz> <20121125011047.7477BB5E@pobox.sk> <20121125120524.GB10623@dhcp22.suse.cz> <20121125135542.GE10623@dhcp22.suse.cz> <20121126013855.AF118F5E@pobox.sk> <20121126131837.GC17860@dhcp22.suse.cz> <50B403CA.501@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50B403CA.501@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: Kamezawa Hiroyuki Cc: azurIt , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups mailinglist , Johannes Weiner On Tue 27-11-12 09:05:30, KAMEZAWA Hiroyuki wrote: [...] > As a short term fix, I think this patch will work enough and seems simple enough. > Acked-by: KAMEZAWA Hiroyuki Thanks! If Johannes is also ok with this for now I will resubmit the patch to Andrew after I hear back from the reporter. > Reading discussion between you and Johannes, to release locks, I understand > the memcg need to return "RETRY" for a long term fix. Thinking a little, > it will be simple to return "RETRY" to all processes waited on oom kill queue > of a memcg and it can be done by a small fixes to memory.c. I wouldn't call it simple but it is doable. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org