From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx172.postini.com [74.125.245.172]) by kanga.kvack.org (Postfix) with SMTP id 5DEAB6B00C2 for ; Wed, 21 Nov 2012 07:01:43 -0500 (EST) Subject: Re: [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages From: Maxim Patlasov Date: Wed, 21 Nov 2012 16:01:28 +0400 Message-ID: <20121121115314.20471.52148.stgit@maximpc.sw.ru> In-Reply-To: <20121116171039.3196.92186.stgit@maximpc.sw.ru> References: <20121116171039.3196.92186.stgit@maximpc.sw.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: miklos@szeredi.hu Cc: dev@parallels.com, xemul@parallels.com, fuse-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, jbottomley@parallels.com, linux-mm@kvack.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Added linux-mm@ to cc:. The patch can stand on it's own. > Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP > counter is high enough. This prevents us from having too many dirty > pages on fuse, thus giving the userspace part of it a chance to write > stuff properly. > > Note, that the existing balance logic is per-bdi, i.e. if the fuse > user task gets stuck in the function this means, that it either > writes to the mountpoint it serves (but it can deadlock even without > the writeback) or it is writing to some _other_ dirty bdi and in the > latter case someone else will free the memory for it. Signed-off-by: Maxim V. Patlasov Signed-off-by: Pavel Emelyanov --- mm/page-writeback.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 830893b..499a606 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1220,7 +1220,8 @@ static void balance_dirty_pages(struct address_space *mapping, */ nr_reclaimable = global_page_state(NR_FILE_DIRTY) + global_page_state(NR_UNSTABLE_NFS); - nr_dirty = nr_reclaimable + global_page_state(NR_WRITEBACK); + nr_dirty = nr_reclaimable + global_page_state(NR_WRITEBACK) + + global_page_state(NR_WRITEBACK_TEMP); global_dirty_limits(&background_thresh, &dirty_thresh); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org