From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx190.postini.com [74.125.245.190]) by kanga.kvack.org (Postfix) with SMTP id 617166B002B for ; Thu, 15 Nov 2012 04:02:07 -0500 (EST) Date: Thu, 15 Nov 2012 10:02:04 +0100 From: Michal Hocko Subject: Re: [patch 2/4] mm, oom: cleanup pagefault oom handler Message-ID: <20121115090204.GA11990@dhcp22.suse.cz> References: <50A4AB9E.4030106@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50A4AB9E.4030106@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: Kamezawa Hiroyuki Cc: David Rientjes , Andrew Morton , KOSAKI Motohiro , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Thu 15-11-12 17:45:18, KAMEZAWA Hiroyuki wrote: > (2012/11/14 18:15), David Rientjes wrote: [...] > >@@ -708,15 +671,17 @@ out: > > > > /* > > * The pagefault handler calls here because it is out of memory, so kill a > >- * memory-hogging task. If a populated zone has ZONE_OOM_LOCKED set, a parallel > >- * oom killing is already in progress so do nothing. If a task is found with > >- * TIF_MEMDIE set, it has been killed so do nothing and allow it to exit. > >+ * memory-hogging task. If any populated zone has ZONE_OOM_LOCKED set, a > >+ * parallel oom killing is already in progress so do nothing. > > */ > > void pagefault_out_of_memory(void) > > { > >- if (try_set_system_oom()) { > >+ struct zonelist *zonelist = node_zonelist(first_online_node, > >+ GFP_KERNEL); > > > why GFP_KERNEL ? not GFP_HIGHUSER_MOVABLE ? I was wondering about the same but gfp_zonelist cares only about __GFP_THISNODE so GFP_HIGHUSER_MOVABLE doesn't do any difference. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org