From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx143.postini.com [74.125.245.143]) by kanga.kvack.org (Postfix) with SMTP id 53ED66B0070 for ; Mon, 12 Nov 2012 20:13:34 -0500 (EST) Date: Mon, 12 Nov 2012 20:13:29 -0500 From: Johannes Weiner Subject: Re: [PATCH 4/4] bootmem: fix wrong call parameter for free_bootmem() Message-ID: <20121113011329.GF10092@cmpxchg.org> References: <1352737915-30906-1-git-send-email-js1304@gmail.com> <1352737915-30906-4-git-send-email-js1304@gmail.com> <20121113011027.GE10092@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121113011027.GE10092@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt On Mon, Nov 12, 2012 at 08:10:27PM -0500, Johannes Weiner wrote: > On Tue, Nov 13, 2012 at 01:31:55AM +0900, Joonsoo Kim wrote: > > It is somehow strange that alloc_bootmem return virtual address > > and free_bootmem require physical address. > > Anyway, free_bootmem()'s first parameter should be physical address. > > > > There are some call sites for free_bootmem() with virtual address. > > So fix them. > > > > Cc: Andrew Morton > > Cc: Benjamin Herrenschmidt > > Signed-off-by: Joonsoo Kim > > Found another one, attached below. The free_bootmem() in > arch/powerpc/platforms/82xx/pq2ads-pci-pic.c looks also fishy, since > it's applied to memory from kzalloc(). Ben? Eh, missed the smu.c one in Joonsoo's patch. powerpc one still strange. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org