From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx147.postini.com [74.125.245.147]) by kanga.kvack.org (Postfix) with SMTP id C32746B0044 for ; Tue, 6 Nov 2012 09:46:47 -0500 (EST) Received: by mail-ee0-f41.google.com with SMTP id c4so390545eek.14 for ; Tue, 06 Nov 2012 06:46:46 -0800 (PST) Date: Tue, 6 Nov 2012 15:46:44 +0100 From: Michal Hocko Subject: Re: [PATCH 1/2] mm: Export vm_committed_as Message-ID: <20121106144644.GA29017@dhcp22.suse.cz> References: <1349654347-18337-1-git-send-email-kys@microsoft.com> <1349654386-18378-1-git-send-email-kys@microsoft.com> <20121008004358.GA12342@kroah.com> <426367E2313C2449837CD2DE46E7EAF930A1FB31@SN2PRD0310MB382.namprd03.prod.outlook.com> <20121008133539.GA15490@kroah.com> <20121009124755.ce1087b4.akpm@linux-foundation.org> <426367E2313C2449837CD2DE46E7EAF930DF7FBB@SN2PRD0310MB382.namprd03.prod.outlook.com> <20121105134456.f655b85a.akpm@linux-foundation.org> <426367E2313C2449837CD2DE46E7EAF930DFA7B8@SN2PRD0310MB382.namprd03.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: KY Srinivasan , Andrew Morton , Greg KH , "olaf@aepfle.de" , "linux-kernel@vger.kernel.org" , "andi@firstfloor.org" , "apw@canonical.com" , "devel@linuxdriverproject.org" , "linux-mm@kvack.org" , Hiroyuki Kamezawa , Johannes Weiner , Ying Han On Mon 05-11-12 14:33:12, David Rientjes wrote: > On Mon, 5 Nov 2012, KY Srinivasan wrote: > > > The Hyper-V host has a policy engine for managing available physical memory across > > competing virtual machines. This policy decision is based on a number of parameters > > including the memory pressure reported by the guest. Currently, the pressure calculation is > > based on the memory commitment made by the guest. From what I can tell, the ratio of > > currently allocated physical memory to the current memory commitment made by the guest > > (vm_committed_as) is used as one of the parameters in making the memory balancing decision on > > the host. This is what Windows guests report to the host. So, I need some measure of memory > > commitments made by the Linux guest. This is the reason I want export vm_committed_as. > > > > I don't think you should export the symbol itself to modules but rather a > helper function that returns s64 that just wraps > percpu_counter_read_positive() which your driver could use instead. Agreed, we should rather make sure that nobody can manipulate the value from modules. > (And why percpu_counter_read_positive() returns a signed type is a > mystery.) Strange indeed. The last commit changed it from long to s64 to suport values bigger than 2^31 but even the original long doesn't make much sense to me. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org