From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx180.postini.com [74.125.245.180]) by kanga.kvack.org (Postfix) with SMTP id 5FCB06B005D for ; Fri, 19 Oct 2012 09:34:17 -0400 (EDT) Date: Fri, 19 Oct 2012 15:34:15 +0200 From: Michal Hocko Subject: Re: [PATCH 4/6] cgroups: forbid pre_destroy callback to fail Message-ID: <20121019133415.GF799@dhcp22.suse.cz> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-5-git-send-email-mhocko@suse.cz> <20121018224148.GR13370@google.com> <20121018224606.GS13370@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121018224606.GS13370@google.com> Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh On Thu 18-10-12 15:46:06, Tejun Heo wrote: > On Thu, Oct 18, 2012 at 03:41:48PM -0700, Tejun Heo wrote: > > Note that the patch is broken in a couple places but it does show the > > general direction. I'd prefer if patch #3 simply makes pre_destroy() > > return 0 and drop __DEPRECATED_clear_css_refs from mem_cgroup_subsys. > > Then, I can pull the branch in and drop all the unnecessary cruft. > > But you need the locking change for further memcg cleanup. To avoid > interlocked pulls from both sides, I think it's okay to push this one > with the rest of memcg changes. I can do the cleanup on top of this > whole series, but please do drop .__DEPRECATED_clear_css_refs from > memcg. OK I will drop that one. > Acked-by: Tejun Heo Do you still agree with the v2 based on Li's feedback? Thanks -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org